Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appengine: Suppress null automatic_scaling blocks during Read #7262

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#17531

I went with this over O+C or a DSF because the field exists in a oneof (scaling in proto) and those options both preserve the set-but-deeply-nil automatic_scaling block in state, meaning we'd eventually send it to the server even if the user was sending a different scaling entry. This approach is worse if they start returning values for existing fields because it will break users again, but it's at least mitigatable with lifecycle.ignore_changes if that happens.

Release Note Template for Downstream PRs (will be copied)

appengine: added suppression for a diff in google_app_engine_standard_app_version.automatic_scaling when the block is unset in configuration

Derived from GoogleCloudPlatform/magic-modules#10476

[upstream:b27fe0a9d25ae29790edee20e14c93fa80bd3aa1]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 2b3bac5 into hashicorp:main Apr 18, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-b27fe0a9d25ae29790edee20e14c93fa80bd3aa1 branch November 16, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccAppEngine* tests with automatic_scaling
1 participant