appengine: Suppress null automatic_scaling blocks during Read

[rileykarson]

Fixes hashicorp/terraform-provider-google#17531

I went with this over O+C or a DSF because the field exists in a oneof (scaling in proto) and those options both preserve the set-but-deeply-nil automatic_scaling block in state, meaning we'd eventually send it to the server even if the user was sending a different scaling entry. This approach is worse if they start returning values for existing fields because it will break users again, but it's at least mitigatable with lifecycle.ignore_changes if that happens.

Release Note Template for Downstream PRs (will be copied)

appengine: added suppression for a diff in google_app_engine_standard_app_version.automatic_scaling when the block is unset in configuration

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 27 insertions(+))
google-beta provider: Diff ( 1 file changed, 27 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineStandardAppVersion_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

I think TestAccAppEngineFlexibleAppVersion_update failed because it and TestAccAppEngineStandardAppVersion_update fight over the same singleton resources and were run literally in parallel here. I'll update them.

This should pass after /gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 27 insertions(+))
google-beta provider: Diff ( 1 file changed, 27 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Hmm- new error. /gcbrun

[rileykarson]

Ah, I misread the initial failure. I misread an intended update call as the failing reason. The reason seems to be:

ERROR: No matching distribution found for gunicorn==22.0.0 (from -r requirements.txt (line 2))

So unrelated to this change. Not sure why it's not failing in the nightlies then.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 27 insertions(+))
google-beta provider: Diff ( 1 file changed, 27 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

Ah- it was #10469, that didn't run in VCR because it didn't modify a code file. #10477 to revert.

[rileykarson]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 27 insertions(+))
google-beta provider: Diff ( 1 file changed, 27 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineStandardAppVersion_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[c2thorn]

Not in love with the downsides of this maintenance-wise, but it seems better for the user experience.

[rileykarson]

Not in love with the downsides of this maintenance-wise, but it seems better for the user experience.

Yeah- being in a oneof is the justification for taking this approach.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 29 insertions(+))
google-beta provider: Diff ( 1 file changed, 29 insertions(+))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• appengine

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log