Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA encrypted_interconnect_router on compute router #3807

Conversation

modular-magician
Copy link
Collaborator

Fixes tests in GA provider that were passing in beta provider.

This field should hav been released in GA along with GoogleCloudPlatform/magic-modules#4983 and GoogleCloudPlatform/magic-modules#4777

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample
=== PAUSE TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample
=== CONT  TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample
--- PASS: TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample (105.92s)
PASS
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample
=== PAUSE TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample
=== CONT  TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample
--- PASS: TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample (82.78s)
PASS
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccComputeRouter_computeRouterEncryptedInterconnectExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccComputeRouter_computeRouterEncryptedInterconnectExample
=== PAUSE TestAccComputeRouter_computeRouterEncryptedInterconnectExample
=== CONT  TestAccComputeRouter_computeRouterEncryptedInterconnectExample
--- PASS: TestAccComputeRouter_computeRouterEncryptedInterconnectExample (59.94s)
PASS

in the GA provider.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `encrypted_interconnect_router` to `google_compute_router` (GA only)

Derived from GoogleCloudPlatform/magic-modules#5397

* GA encrypted_interconnect_router on compute router

* Readd note on encrypted interconnect not being GA

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a3a7630 into hashicorp:master Oct 29, 2021
@modular-magician modular-magician deleted the downstream-pr-372db4df7e7e1ae866b8855463c1a18ec779cc4b branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant