-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPsec-encrypted Interconnect #4777
IPsec-encrypted Interconnect #4777
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 7 files changed, 323 insertions(+), 22 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=186821" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 322 insertions(+), 22 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=186850" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample|TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeRouter_computeRouterEncryptedInterconnectExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=186948" |
92a9ede
to
dc8edfa
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 6 files changed, 322 insertions(+), 22 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187215" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRouter_computeRouterEncryptedInterconnectExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187321" |
Might need some allowlisting of CI project to get tests to pass. This feature is currently not publicly available, and users must have their project specifically allowed to use it. This is somewhat similar to how interconnect itself works, so this is not too unusual
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)