Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPsec-encrypted Interconnect #4777

Merged
merged 3 commits into from
May 14, 2021

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented May 11, 2021

Might need some allowlisting of CI project to get tests to pass. This feature is currently not publicly available, and users must have their project specifically allowed to use it. This is somewhat similar to how interconnect itself works, so this is not too unusual

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added support for IPsec-encrypted Interconnect in the form of new fields on `google_compute_router`, `google_compute_ha_vpn_gateway`, `google_compute_interconnect_attachment` and `google_compute_address` (beta only)

@google-cla google-cla bot added the cla: yes label May 11, 2021
@slevenick slevenick changed the title IPsec over interconnect feature IPsec-encrypted Interconnect May 11, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 323 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 13 files changed, 1702 insertions(+), 29 deletions(-))
Ansible: Diff ( 2 files changed, 21 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))
TF OiCS: Diff ( 16 files changed, 544 insertions(+))
Inspec: Diff ( 8 files changed, 22 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=186821"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 322 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 12 files changed, 805 insertions(+), 29 deletions(-))
Ansible: Diff ( 2 files changed, 21 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))
TF OiCS: Diff ( 16 files changed, 544 insertions(+))
Inspec: Diff ( 8 files changed, 22 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=186850"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample|TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeRouter_computeRouterEncryptedInterconnectExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=186948"

@slevenick slevenick force-pushed the ipsec-interconnect branch from 92a9ede to dc8edfa Compare May 13, 2021 23:45
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 322 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 12 files changed, 795 insertions(+), 29 deletions(-))
Ansible: Diff ( 2 files changed, 21 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))
TF OiCS: Diff ( 16 files changed, 544 insertions(+))
Inspec: Diff ( 8 files changed, 22 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187215"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRouter_computeRouterEncryptedInterconnectExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=187321"

@slevenick slevenick requested a review from rileykarson May 14, 2021 16:11
mmv1/products/compute/api.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants