Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated out tgc test results as a different status #3335

Conversation

modular-magician
Copy link
Collaborator

This uses the statuses API to split out the results for terraform-google-conversion tests from generate-diffs. Note that this means that the script should only have a nonzero exit code if the script itself fails; the tests failing will no longer cause generate_diffs to fail (which is what we want. These test failures will be tracked by this new status instead.)

I can't test this fully because it requires rebuilding the docker containers. Doing tgc first lets us test it out with a relatively low-traffic component before doing the same conversion with e.g. tpg and tpgb.

I've tested this locally as much as I can - i.e. running the curl logic with a personal access token instead of the Magician's.


Derived from GoogleCloudPlatform/magic-modules#4865

@modular-magician modular-magician merged commit 776bc69 into hashicorp:master Jun 11, 2021
@modular-magician modular-magician deleted the downstream-pr-d05e368e926d4673ef7a7a82290fdb34250ad329 branch November 16, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant