Separated out tgc test results as a different status #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the statuses API to split out the results for terraform-google-conversion tests from generate-diffs. Note that this means that the script should only have a nonzero exit code if the script itself fails; the tests failing will no longer cause generate_diffs to fail (which is what we want. These test failures will be tracked by this new status instead.)
I can't test this fully because it requires rebuilding the docker containers. Doing tgc first lets us test it out with a relatively low-traffic component before doing the same conversion with e.g. tpg and tpgb.
I've tested this locally as much as I can - i.e. running the curl logic with a personal access token instead of the Magician's.