Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolved hashicorp/terraform-provider-google#8251.
I think the issue is that "preview" is optional; if it wasn't provided, it would be tracked as nil by the provider and "false" by the state. When the user goes to make a plan, terraform detects that "preview" will be updated from false -> null, which changes the hash of the object (which looks like a delete/recreate.) Changing to Computed fixes this by setting the provider's value from the API as well as the state.
There is a separate issue where changes are still erroneously detected if a match uses expr instead of config - I'm having some trouble figuring out the best solution in that case but wanted to get the first part out there at least :-)
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#4472