Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom info types to inspect template. #2648

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#7625

Couple of fields not supported, as they are marked as deprecated or structure undocumented

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dlp: added `custom_info_types` to `google_dlp_inspect_template`

Derived from GoogleCloudPlatform/magic-modules#4146

* Add support for custom info types to inspect template.

* Add use in hotword rule

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added size/xl labels Oct 27, 2020
@modular-magician modular-magician merged commit 12ae0c3 into hashicorp:master Oct 27, 2020
@modular-magician modular-magician deleted the downstream-pr-9faf2b7fd45795ba27e40896e93c27da5a1e631e branch November 16, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom_info_types to google_data_loss_prevention_inspect_template
1 participant