Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom info types to inspect template. #4146

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

slevenick
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#7625

Couple of fields not supported, as they are marked as deprecated or structure undocumented

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dlp: added `custom_info_types` to `google_dlp_inspect_template`

@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 716 insertions(+))
Terraform Beta: Diff ( 3 files changed, 716 insertions(+))
TF Conversion: Diff ( 1 file changed, 224 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153888"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccContainerCluster_withConfidentialNodes|TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateCustomTypeExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153971"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 754 insertions(+))
Terraform Beta: Diff ( 3 files changed, 754 insertions(+))
TF Conversion: Diff ( 1 file changed, 224 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=154608"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccIapTunnelIamBindingGenerated|TestAccIapTunnelIamMemberGenerated|TestAccIapTunnelIamPolicyGenerated|TestAccIapTunnelIamBindingGenerated_withCondition|TestAccIapTunnelIamMemberGenerated_withCondition|TestAccIapTunnelIamPolicyGenerated_withCondition|TestAccBigqueryDataTransferConfig|TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateCustomTypeExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=154613"

@slevenick slevenick requested review from rileykarson and nat-henderson and removed request for rileykarson October 27, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom_info_types to google_data_loss_prevention_inspect_template
3 participants