clarify specification of audit log types #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is intended to avoid the confusion outlined in hashicorp/terraform-provider-google#5446, which I also ran into. Having multiple audit logs in the example should make it readily apparent how the resource is intended to be used. Signed-off-by: Modular Magician <[email protected]>
ghost
added
modular-magician
deleted the
downstream-pr-618500a327c536fdc368867b0eada0c5cf44f707
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to avoid the confusion outlined in
hashicorp/terraform-provider-google#5446,
which I also ran into. Having multiple audit logs in the example should
make it readily apparent how the resource is intended to be used.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3136