Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify specification of audit log types #3136

Merged

Conversation

kujenga
Copy link
Contributor

@kujenga kujenga commented Feb 17, 2020

This change is intended to avoid the confusion outlined in
hashicorp/terraform-provider-google#5446,
which I also ran into. Having multiple audit logs in the example should
make it readily apparent how the resource is intended to be used.

Release Note Template for Downstream PRs (will be copied)

Improve documentation for multiple log_type values in google_project_iam_audit_config resource

This change is intended to avoid the confusion outlined in
hashicorp/terraform-provider-google#5446,
which I also ran into. Having multiple audit logs in the example should
make it readily apparent how the resource is intended to be used.
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 1 file changed, 3 insertions(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@chrisst
Copy link
Contributor

chrisst commented Mar 30, 2020

Thanks for clarifying!

@chrisst chrisst merged commit 618500a into GoogleCloudPlatform:master Mar 30, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
This change is intended to avoid the confusion outlined in
hashicorp/terraform-provider-google#5446,
which I also ran into. Having multiple audit logs in the example should
make it readily apparent how the resource is intended to be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants