Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerate IAM resources for IAP Tunnel Instance #1654

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Autogenerate IAM resources for IAP Tunnel Instance #1654

merged 1 commit into from
Jan 17, 2020

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Jan 17, 2020 •
edited by paddycarver
Loading

Original Author: @emilymye

iap: added support for IAM conditions in `google_iap_tunnel_instance_iam_*` IAM resources

iap: Changed resource ID for `google_iap_tunnel_instance_iam_*` IAM resources from `projects/{{project_number}}/iap_tunnel/zones/{{zones}}/instances/{{instance}}` to 
`projects/{{project}}/iap_tunnel/zones/{{zones}}/instances/{{instance}}` to maintain similar formats to other resources and avoid making unnecessary additional requests to GCP to get project number.

@modular-magician modular-magician mentioned this pull request Jan 17, 2020
Merged
@modular-magician modular-magician force-pushed the codegen-pr-2988 branch 3 times, most recently from f56a52e to f11df06 Compare January 17, 2020 19:56
@emilymye emilymye merged commit fc1f518 into hashicorp:master Jan 17, 2020
@modular-magician modular-magician deleted the codegen-pr-2988 branch November 16, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye left review comments

@slevenick slevenick slevenick left review comments

Assignees
No one assigned
Labels
documentation size/xxl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modular-magician @slevenick @emilymye