-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate IAM resources for IAP Tunnel Instance #2988
Autogenerate IAM resources for IAP Tunnel Instance #2988
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
iam_conditions_request_type: :REQUEST_BODY | ||
id_format: "projects/{{project}}/iap_tunnel/zones/{{zone}}/instances/{{name}}" | ||
import_format: [ | ||
"projects/{{project}}/iap_tunnel/zones/{{zone}}/instances/{{name}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the handwritten has "projects/{{project}}/iap_tunnel/zones/{{zone}}/instances/{{instance}}"
for id and "projects/{{project}}/zones/{{zone}}/instances/{{instance}}"
for import format, so we're keeping ID format and supporting both import formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! There is something strange going on with the downstreams though, they have conflicts
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
5aa4845
to
0da33ab
Compare
to
While IAP in documentation says they only allow for project number, they actually support projectId. This change keeps TunnelInstance in line with both other IAP IAM resources and the rest of Terraform (by using project ID) and avoids two extra calls (and the necessary permissions) to fetch the project from the Cloud Resource Manager API and get the project number for an ID.
Release Note Template for Downstream PRs (will be copied)