-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default_if_empty to google_compute_router_nat defaults #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
size/xs
label
Jan 9, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
force-pushed
the
codegen-pr-2946
branch
from
January 9, 2020 01:42
05d5b4a
to
98292cf
Compare
modular-magician
added a commit
that referenced
this pull request
Jan 9, 2020
* Allow domain mapping to succeed if DNS is pending Signed-off-by: Modular Magician <magic-modules@google.com> * Update google_folder import description (#1592) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * add google_kms_secret_ciphertext resource, deprecate datasource (#1586) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * Allow add/removing Bigtable clusters (#1589) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Add bootstrapped test networks for service networking tests (#1588) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Update CHANGELOG.md * fix docs for google_bigquery_default_service_account (#1596) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Martin Nowak <code@dawg.eu> * Nil return for absent Bigtable resources (#1597) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> * add lifecycle_config to dataproc_cluster.cluster_config Signed-off-by: Modular Magician <magic-modules@google.com> * Add warnings about custom role format for IAM bindings (#1600) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Add mutex to peering create (#1601) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Add default_if_empty for quic_override (#1611) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Batch errors now indicate how to disable batching Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty to google_compute_router_nat defaults (#1613) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Allow for retries of single requests in a batch on failure (#1615) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Add default_if_empty to google_compute_router_nat defaults (#2946) Merged PR #2946. Co-authored-by: Chris Stephens <chrisst@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: emily <emilyye@google.com> Co-authored-by: Paddy <paddy@hashicorp.com> Co-authored-by: Martin Nowak <code@dawg.eu> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> Co-authored-by: megan07 <mbang@hashicorp.com>
modular-magician
added a commit
that referenced
this pull request
Jan 9, 2020
* Allow domain mapping to succeed if DNS is pending Signed-off-by: Modular Magician <magic-modules@google.com> * Update google_folder import description (#1592) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * add google_kms_secret_ciphertext resource, deprecate datasource (#1586) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * Allow add/removing Bigtable clusters (#1589) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Add bootstrapped test networks for service networking tests (#1588) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Update CHANGELOG.md * fix docs for google_bigquery_default_service_account (#1596) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Martin Nowak <code@dawg.eu> * Nil return for absent Bigtable resources (#1597) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> * add lifecycle_config to dataproc_cluster.cluster_config Signed-off-by: Modular Magician <magic-modules@google.com> * Add warnings about custom role format for IAM bindings (#1600) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Add mutex to peering create (#1601) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Handle aggregatedList case for generated sweepers Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty for quic_override (#1611) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Batch errors now indicate how to disable batching Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty to google_compute_router_nat defaults (#1613) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Allow for retries of single requests in a batch on failure (#1615) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Allow for retries of single requests in a batch on failure (#2947) Merged PR #2947. Co-authored-by: Chris Stephens <chrisst@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: emily <emilyye@google.com> Co-authored-by: Paddy <paddy@hashicorp.com> Co-authored-by: Martin Nowak <code@dawg.eu> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Cameron Thornton <camthornton@google.com>
modular-magician
added a commit
that referenced
this pull request
Jan 9, 2020
* Allow domain mapping to succeed if DNS is pending Signed-off-by: Modular Magician <magic-modules@google.com> * Update google_folder import description (#1592) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * add google_kms_secret_ciphertext resource, deprecate datasource (#1586) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * Allow add/removing Bigtable clusters (#1589) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Add bootstrapped test networks for service networking tests (#1588) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Update CHANGELOG.md * fix docs for google_bigquery_default_service_account (#1596) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Martin Nowak <code@dawg.eu> * Nil return for absent Bigtable resources (#1597) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> * add lifecycle_config to dataproc_cluster.cluster_config Signed-off-by: Modular Magician <magic-modules@google.com> * Add warnings about custom role format for IAM bindings (#1600) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Add mutex to peering create (#1601) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Handle aggregatedList case for generated sweepers Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty for quic_override (#1611) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Batch errors now indicate how to disable batching Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty to google_compute_router_nat defaults (#1613) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Allow for retries of single requests in a batch on failure (#1615) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Handle aggregatedList case for generated sweepers (#2941) Merged PR #2941. Co-authored-by: Chris Stephens <chrisst@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: emily <emilyye@google.com> Co-authored-by: Paddy <paddy@hashicorp.com> Co-authored-by: Martin Nowak <code@dawg.eu> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Cameron Thornton <camthornton@google.com>
modular-magician
added a commit
that referenced
this pull request
Jan 9, 2020
* Allow domain mapping to succeed if DNS is pending Signed-off-by: Modular Magician <magic-modules@google.com> * Update google_folder import description (#1592) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * add google_kms_secret_ciphertext resource, deprecate datasource (#1586) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * Allow add/removing Bigtable clusters (#1589) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Add bootstrapped test networks for service networking tests (#1588) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Update CHANGELOG.md * fix docs for google_bigquery_default_service_account (#1596) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Martin Nowak <code@dawg.eu> * Nil return for absent Bigtable resources (#1597) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> * add lifecycle_config to dataproc_cluster.cluster_config Signed-off-by: Modular Magician <magic-modules@google.com> * Add warnings about custom role format for IAM bindings (#1600) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Add mutex to peering create (#1601) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Handle aggregatedList case for generated sweepers Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty for quic_override (#1611) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Batch errors now indicate how to disable batching Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty to google_compute_router_nat defaults (#1613) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Allow for retries of single requests in a batch on failure (#1615) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Avoid panic in usage_export_bucket Signed-off-by: Modular Magician <magic-modules@google.com> * Add validation for start_time to resource_policy Signed-off-by: Modular Magician <magic-modules@google.com> * Batch errors now indicate how to disable batching (#2944) Merged PR #2944. Co-authored-by: Chris Stephens <chrisst@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: emily <emilyye@google.com> Co-authored-by: Paddy <paddy@hashicorp.com> Co-authored-by: Martin Nowak <code@dawg.eu> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Cameron Thornton <camthornton@google.com>
modular-magician
added a commit
that referenced
this pull request
Jan 9, 2020
* Allow domain mapping to succeed if DNS is pending Signed-off-by: Modular Magician <magic-modules@google.com> * Update google_folder import description (#1592) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * add google_kms_secret_ciphertext resource, deprecate datasource (#1586) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> * Allow add/removing Bigtable clusters (#1589) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Add bootstrapped test networks for service networking tests (#1588) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Update CHANGELOG.md * fix docs for google_bigquery_default_service_account (#1596) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Martin Nowak <code@dawg.eu> * Nil return for absent Bigtable resources (#1597) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> * add lifecycle_config to dataproc_cluster.cluster_config Signed-off-by: Modular Magician <magic-modules@google.com> * Add warnings about custom role format for IAM bindings (#1600) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Add mutex to peering create (#1601) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Handle aggregatedList case for generated sweepers Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty for quic_override (#1611) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Batch errors now indicate how to disable batching Signed-off-by: Modular Magician <magic-modules@google.com> * Add default_if_empty to google_compute_router_nat defaults (#1613) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> * Allow for retries of single requests in a batch on failure (#1615) Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: emily <emilyye@google.com> * Avoid panic in usage_export_bucket Signed-off-by: Modular Magician <magic-modules@google.com> * Add validation for start_time to resource_policy Signed-off-by: Modular Magician <magic-modules@google.com> * Add validation for start_time to resource_policy (#2940) Merged PR #2940. Co-authored-by: Chris Stephens <chrisst@google.com> Co-authored-by: Dana Hoffman <danahoffman@google.com> Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: emily <emilyye@google.com> Co-authored-by: Paddy <paddy@hashicorp.com> Co-authored-by: Martin Nowak <code@dawg.eu> Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com> Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Cameron Thornton <camthornton@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Author: @rileykarson