Breaking change: SDK v2 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kmoe
commented
Oct 3, 2020
kmoe
commented
- Upgrade to SDK v2.0.3 with reattach binary testing
- Match scaffolding provider directory layout
- Remove outdated website targets in Makefile
- Update Go version in Travis CI
|
The test failure is preexisting on |
|
Test failures were due to flakiness that will be dealt with in #112 - fixed for now by adding the missing DNS records to the test files. |
Automates the protocol 5 only setting on release. This file can be removed when all providers have been upgraded to SDKv2.
paultyng
approved these changes
Oct 8, 2020
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.