Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create permanent terraform.io TXT record for testing #112

Closed
kmoe opened this issue Oct 8, 2020 · 3 comments · Fixed by #158
Closed

Create permanent terraform.io TXT record for testing #112

kmoe opened this issue Oct 8, 2020 · 3 comments · Fixed by #158
Assignees
@bflad
Labels
tests

Comments

@kmoe
Copy link
Member

kmoe commented Oct 8, 2020

TestAccDataDnsTxtRecordSet_Basic does a real-world check of the TXT records for the terraform.io domain, as pointed out in #106. This causes the test to fail whenever these change.

Add a permanent TXT record for testing this functionality, or perhaps use another domain where we have full control over the TXT records.
@kmoe kmoe added the tests label Oct 8, 2020
@kmoe
Copy link
Member Author

kmoe commented Oct 8, 2020

This is also true for the CNAME test, TestAccDataDnsCnameRecordSet_Basic. We probably want to consider dedicated infra for testing this provider.

This was referenced Oct 8, 2020
Merged
Closed
@bflad bflad self-assigned this Jul 8, 2021
@bflad
Copy link
Contributor

bflad commented Jul 8, 2021

The Terraform team does have hashicorptest.com available for use in CloudFlare and managed via Terraform (Cloud). Happy to pick this up so we can get consistent testing. 😄 If/when testing changes are made, I can also add some comments for future travelers about record management there.

@kmoe kmoe mentioned this issue Jul 8, 2021
Closed
bflad added a commit that referenced this issue Jul 26, 2021
@bflad
tests: Switch to hashicorptest.com DNS records for testing
2f28373 
Reference: #112
Reference: #144
Reference: #154
Reference: #157
bflad added a commit that referenced this issue Jul 26, 2021
@bflad
tests: Switch to hashicorptest.com DNS records for testing
9ffd097 
Reference: https://github.com/hashicorp/tf-eco-acctest-infrastructure/issues/61
Reference: #112
Reference: #144
Reference: #154
Reference: #157
@bflad bflad mentioned this issue Jul 26, 2021
Merged
bflad added a commit that referenced this issue Jul 27, 2021
@bflad
tests: Switch to hashicorptest.com DNS records for testing
733ad76 
Reference: https://github.com/hashicorp/tf-eco-acctest-infrastructure/issues/61
Reference: #112
Reference: #144
Reference: #154
Reference: #157
bflad added a commit that referenced this issue Jul 27, 2021
@bflad
tests: Switch to hashicorptest.com DNS records for testing (#158)
69966bb 
Reference: https://github.com/hashicorp/tf-eco-acctest-infrastructure/issues/61
Reference: #112
Reference: #144
Reference: #154
Reference: #157
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Switch to hashicorptest.com DNS records for testing hashicorp/terraform-provider-dns
2 participants
@bflad @kmoe