feat(policies): support storage policies within terraform #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisruch
requested changes
Feb 6, 2024
Comment on lines
71
to
79
| var policy_type string | ||
| switch { | ||
| case strings.HasPrefix(policyId, policyStoragePolicyPrefix): | ||
| if _, err := scp.AttachStoragePolicy(ctx, scopeId, 0, policyId, opts...); err != nil { | ||
| return diag.FromErr(err) | ||
| } | ||
| policy_type = "storage" | ||
| default: | ||
| return diag.Errorf("unknown policy type provided.") | ||
| } |
There was a problem hiding this comment.
Not sure we need the check here, but this should only ever support storage policy types so if you really want a check you can just do the if strings.HasPrefix, though if you are doing this check you should check that the scopeId is global or that of an org scope only as well
kheina
force-pushed
the
dmiu_storage-policies
branch
3 times, most recently
from
987270b to
4e86cae
Compare
louisruch
requested changes
Feb 7, 2024
louisruch
reviewed
Feb 7, 2024
kheina
force-pushed
the
dmiu_storage-policies
branch
3 times, most recently
from
58a9855 to
de1f0ce
Compare
kheina
force-pushed
the
dmiu_storage-policies
branch
from
de1f0ce to
793fa38
Compare
kheina
force-pushed
the
dmiu_storage-policies
branch
from
793fa38 to
4e69d50
Compare
kheina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: requires hashicorp/boundary#4385 to be merged and tagged and go.mod updated before merging and deploying
testing was done manually due to policies being an enterprise feature