Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(policies): Update SDK/API to support setting/clearing attributes #4385

Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat(policies): Update SDK/API to support setting/clearing attributes #4385

merged 1 commit into from
Feb 9, 2024

Conversation

louisruch
Copy link
Collaborator

No description provided.

@louisruch louisruch requested a review from hugoghx February 9, 2024 04:04
@louisruch
Copy link
Collaborator Author

@hugoghx @kheina PTAL this came up form some discussions around the API/SDK for policies when trying to get the TF provider working

@louisruch louisruch added this to the 0.16.x milestone Feb 9, 2024
@louisruch louisruch modified the milestones: 0.16.x, 0.15.x Feb 9, 2024
hugoghx
hugoghx approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@hugoghx hugoghx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember back in the day trying this and it had some CLI issues. Have you checked creating/updating policies using the CLI and UI? If so, LGTM!

@kheina kheina mentioned this pull request Feb 9, 2024
Merged
@louisruch louisruch merged commit d59f089 into main Feb 9, 2024
59 checks passed
@louisruch louisruch deleted the louis-policies-api branch February 9, 2024 17:37
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoghx hugoghx hugoghx approved these changes

Assignees
No one assigned
Labels
api backport/0.15.x core/proto core
Projects
None yet
Milestone
0.15.x
Development

Successfully merging this pull request may close these issues.
3 participants
@louisruch @hugoghx @jefferai