test: Fix failure in TestAccCredentialStoreVault #525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU-11525
Originally, the test
TestAccCredentialStoreVault
was flaky for the following reasonAfter pulling in
boundary 0.14.3
, which included this fix: hashicorp/boundary#3973, the test started to always fail for the following reasonSo, I think
0.14.3
included a fix for the original flaky behavior, but then exposed an issue with the test (the test server sets up a certificate that's only valid forlocalhost
, but we're setting the server name to bewww.updated.com
).This PR also includes an adjustment in the GitHub Action to disable caching in the
setup-go
step. We already handle caching in theSet up Go modules cache
step, and without this adjustment, we were getting duplicate caching, resulting in errors like