fix(vault): Set the Vault TLS client options if specified #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaffney
force-pushed
the
mgaffney-vault-tls-skip-verify-bug
branch
from
fbe3427 to
d1215c3
Compare
johanbrandhorst
approved these changes
Nov 1, 2023
mgaffney
force-pushed
the
mgaffney-vault-tls-skip-verify-bug
branch
from
d1215c3 to
0b26141
Compare
Two Vault client settings were not being properly used when constructing a Vault client. The `TLS Skip Verify` setting was only being set if a `CA Cert` was also configured. This fix sets the `TLS Skip Verify` when configured regardless of other settings. Closes #3961. The `TLS Server Name` setting was never being set. Bad programmers. This fix now sets it on the Vault client if the Vault Credential Store has been configured to use a value for this setting. Closes #3962.
mgaffney
force-pushed
the
mgaffney-vault-tls-skip-verify-bug
branch
from
0b26141 to
d638378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two Vault client settings were not being properly used when constructing a Vault client.
The
TLS Skip Verifysetting was only being set if aCA Certwas also configured. This fix sets theTLS Skip Verifywhen configured regardless of other settings. Closes #3961.The
TLS Server Namesetting was never being set. Bad programmers. This fix now sets it on the Vault client if the Vault Credential Store has been configured to use a value for this setting. Closes #3962.