Support for provisioning Redis Cache in internal network #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/option flag to cover the use case
…pture-description `azurerm_eventhub`: Adding support for CaptureDescription
…s_app New Resource: `azurerm_function_app`
The `enable_accelerated_networking` field is on the NIC and not the VM resource - so the check is invalid
Add Support for Accelerated Networking (SR-IOV)
Upgrading to v12.2.0-beta of the Azure SDK for Go
SDKv12: Vendoring the new versioned SDK needed for each resource
SDKv12: Migrating Traffic Manager and Web to the new SDK
- Updated the examples for consistency - Fixing a highlighting issue in the sidebar - Adding a note that VNG's take a long time to provision
…_network_gateway_connection` (hashicorp#133) Add resources azurerm_virtual_network_gateway and azurerm_virtual_network_gateway_connection
adding set -x to master remote-exec and location arg to masterPrep.sh
Support build and run azure terraform provider on native Windows.
Add support for Azure LB Standard and Public IP Standard
- Fixes a crash when removing the custom_domain field - Enabled removing a custom domain from a storage account
…ing-custom-domain Support for removing a custom domain assigned to a Storage Account
Also adds a couple of TODO's for future refactoring Tests pass: ``` $ acctests azurerm TestAccDataSourceAzureRMBuiltInRoleDefinition_ === RUN TestAccDataSourceAzureRMBuiltInRoleDefinition_contributor --- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_contributor (12.59s) === RUN TestAccDataSourceAzureRMBuiltInRoleDefinition_owner --- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_owner (8.40s) === RUN TestAccDataSourceAzureRMBuiltInRoleDefinition_reader --- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_reader (7.82s) === RUN TestAccDataSourceAzureRMBuiltInRoleDefinition_virtualMachineContributor --- PASS: TestAccDataSourceAzureRMBuiltInRoleDefinition_virtualMachineContributor (9.35s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 38.201s ```
v1.1.0 # gpg: Signatur vom Fr 26 Jan 23:16:03 2018 CET # gpg: mittels RSA-Schlüssel 51852D87348FFC4C # gpg: Korrekte Signatur von "HashiCorp Security <[email protected]>" [unbekannt] # gpg: WARNUNG: Dieser Schlüssel trägt keine vertrauenswürdige Signatur! # gpg: Es gibt keinen Hinweis, daß die Signatur wirklich dem vorgeblichen Besitzer gehört. # Haupt-Fingerabdruck = 91A6 E7F8 5D05 C656 30BE F189 5185 2D87 348F FC4C # Conflicts: # azurerm/resource_arm_redis_cache.go # azurerm/resource_arm_redis_cache_test.go
dominik-lekse
changed the title
|
hey @dominik-lekse Thanks for rebasing this and opening this PR - since this is a rebase and not a merge I've force-pushed this into the Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for adding Redis caches to virtual networks.
@tombuildsstuff I have rebased your original branch
feature/redis-internal-networkto the latestv1.1.0release. I have been doing this for a while now for every custom build of the Azure provider. This time I wanted to share the rebase since with the aging original branch, the rebase becomes more and more time consuming.In my custom build I have been using this feature for quite a while without any problems or surprises. However, I have never deleted any Redis instances and thus did not encounter the
InUseSubnetCannotBeDeletedbug.With regard to the
InUseSubnetCannotBeDeletedbug, it seems to exist also with the most recent SDK v12 :(@tombuildsstuff Please note that this is a pull request into your original
feature/redis-internal-networkand not into master. If you take these changes back into the original branch we can of course close this pull request and open a new one based on the original branch.