New Resource: `azurerm_function_app` #647

JunyiYi · 2017-12-22T01:00:54Z

Add primary_connection_string and secondary_connection_string to azurerm_storage_account resource
Add azurerm_function_app resource to the provider
Add/Update documentations and tests

…nd storage_account.

tombuildsstuff

Thanks for this PR - apologies for the delayed review here!

I've taken a look through and left some comments in-line but this is off to a good start - most of the issues are minor. The one worth mentioning is about the App Settings keys - we need to ensure that the Function App settings are appended to the user specified AppSettings before updating (and that they're removed before setting the value in the state) - otherwise users will have a perpetual diff.

Thanks!

tombuildsstuff · 2018-01-06T09:55:18Z

website/docs/r/function_app.html.markdown

+}
+
+resource "azurerm_storage_account" "test" {
+  name                     = "azure-functions-test-sa"


dashes aren't valid in storage account names, can we make this azurefunctestsa

tombuildsstuff · 2018-01-06T09:56:04Z

website/docs/r/function_app.html.markdown

+
+* `name` - (Required) Specifies the name of the Azure Functions service. Changing this forces a new resource to be created.
+
+* `resource_group_name` - (Required) The name of the resource group in which to create the Azure Functions service.


I think this'd read better if Azure Functions service became just Function App?

tombuildsstuff · 2018-01-06T09:58:05Z

website/docs/r/function_app.html.markdown

+
+Manages an Azure Functions service.
+
+## Example Usage


we should make this Example Usage (within an App Service)

Maybe Example Usage (with App Service Plan) is more accurate.

tombuildsstuff · 2018-01-06T10:03:43Z

website/docs/r/function_app.html.markdown

+
+The following arguments are supported:
+
+* `name` - (Required) Specifies the name of the Azure Functions service. Changing this forces a new resource to be created.


I think this'd read better if Azure Functions service became just Function App?

tombuildsstuff · 2018-01-08T10:42:04Z

azurerm/resource_arm_function_app.go

+				Type:     schema.TypeBool,
+				Optional: true,
+				Default:  true,
+				ForceNew: true,


can we link to the existing issue i.e.

// TODO: support Update once the API is fixed: // https://github.com/Azure/azure-rest-api-specs/issues/1697

tombuildsstuff · 2018-01-08T11:43:51Z

website/docs/r/function_app.html.markdown

+
+# azurerm_function_app
+
+Manages an Azure Functions service.


can we update Azure Functions service -> Function App?

it could be handy to add a blue info box here about Consumption Plans until they can be created natively (e.g. once the computeMode field has been added to the SDK) e.g.

-> **Note:** Function Apps can be deployed to either an App Service Plan or to a Consumption Plan. At this time it's possible to deploy a Function App into an existing Consumption Plan or a new/existing App Service Plan - however it's not currently possible to create a new Consumption Plan. Support for this will be added in the future, and in the interim can be achieved by using [the `azurerm_template_deployment` resource](template_deployment.html).

Can we also open an issue on the Rest API Specs Repository to get these fields added to the Swagger (so it can be added to the SDK)? I'm going to look into adding a Data Source for App Service Plans since I could see referencing an existing App Service Plan being useful (especially in the context mentioned above)

tombuildsstuff · 2018-01-08T11:44:18Z

website/docs/r/function_app.html.markdown

+page_title: "Azure Resource Manager: azurerm_function_app"
+sidebar_current: "docs-azurerm-resource-function-app-x"
+description: |-
+  Manages an Azure Functions service.


can we update Azure Functions service -> Function App?

tombuildsstuff · 2018-01-08T11:45:05Z

website/docs/r/function_app.html.markdown

+---
+layout: "azurerm"
+page_title: "Azure Resource Manager: azurerm_function_app"
+sidebar_current: "docs-azurerm-resource-function-app-x"


we shouldn't need the -x on the end of this (since there's no other resources with the prefix docs-azurerm-resource-function-app at this time)

tombuildsstuff · 2018-01-08T11:46:37Z

website/docs/r/function_app.html.markdown

@@ -0,0 +1,79 @@
+---


can we also add a link to this in the sidebar? I guess it should probably either be in the App Service section or it's own Function App Resources section? https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/website/azurerm.erb#L135

tombuildsstuff · 2018-01-08T12:03:13Z

azurerm/resource_arm_function_app_test.go

+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
+)
+
+func TestAccAzureRMFunctionApp_basic(t *testing.T) {


can we add another acceptance test for going from V1 -> Beta (and back)? It's possible to use multiple test steps to do this and assert on the value of the version field in each step - as we do here: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/resource_arm_traffic_manager_endpoint_test.go#L111

Sure thing.

…ction string.

tombuildsstuff

Hey @JunyiYi

Thanks for pushing those latest updates - I've taken a look and left some comments in-line but this LGTM.

I've pushed a couple of commits to add Import support and fix the documentation; but the tests pass:

$ acctests azurerm TestAccAzureRMFunctionApp_
=== RUN   TestAccAzureRMFunctionApp_importBasic
--- PASS: TestAccAzureRMFunctionApp_importBasic (98.26s)
=== RUN   TestAccAzureRMFunctionApp_basic
--- PASS: TestAccAzureRMFunctionApp_basic (124.61s)
=== RUN   TestAccAzureRMFunctionApp_updateVersion
--- PASS: TestAccAzureRMFunctionApp_updateVersion (126.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	349.276s

Thanks!

tombuildsstuff · 2018-01-11T12:49:02Z

azurerm/resource_arm_function_app_test.go

+	location                  = "${azurerm_resource_group.test.location}"
+	resource_group_name       = "${azurerm_resource_group.test.name}"
+	app_service_plan_id       = "${azurerm_app_service_plan.test.id}"
+	version                   = "%[4]s"


whilst this approach is preferable to reduce repetition - unfortunately there's a bug in golintwhere variables of the wrong type aren't identified when used in this fashion (e.g. as %[1]s vs %s - I think we're safe to leave this for the moment but that's why we format the other way at the moment)

tombuildsstuff · 2018-01-11T14:10:14Z

website/docs/r/function_app.html.markdown

+
+* `id` - The ID of the Function App
+
+* `default_hostname` - The default hostname associated with the Function App - such as `mysite.azurewebsites.net`


going to push an update to add Import documentation here

tombuildsstuff · 2018-01-11T14:10:30Z

website/docs/r/function_app.html.markdown

+
+* `app_settings` - (Optional) A key-value pair of App Settings.
+
+* `enabled` - (Optional) Is the Azure Function service enabled? Changing this forces a new resource to be created.


going to push an update to change this to Function App

tombuildsstuff · 2018-01-11T15:03:25Z

(after testing this - I've also made the field storage_connection_string sensitive, since it's a connection string)

tombuildsstuff · 2018-01-11T15:05:39Z

@JunyiYi thanks for all the work on this - this LGTM 👍

tombuildsstuff · 2018-01-11T16:00:52Z

Whilst verifying this I've ended up pushing a couple of tests to add/update App Settings & Tags - which pass:

ghost · 2020-04-01T14:53:59Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

Junyi Yi added 3 commits December 20, 2017 17:55

Introduce Azure Functions resource azurerm_function_app.

d68cf30

Update the documentation to reflect the new changes of function_app a…

1f25bbe

…nd storage_account.

Add test for the new function_app resource.

f3509b8

JunyiYi requested a review from tombuildsstuff December 22, 2017 01:00

JunyiYi changed the title ~~Introduce azurerm_function_app resource~~ Introduce azurerm_function_app resource Dec 22, 2017

JunyiYi requested a review from metacpp December 22, 2017 01:43

tombuildsstuff changed the title ~~Introduce azurerm_function_app resource~~ New Resource: azurerm_function_app Jan 4, 2018

tombuildsstuff added new-resource service/functions Function Apps labels Jan 8, 2018

tombuildsstuff reviewed Jan 8, 2018

View reviewed changes

tombuildsstuff added the waiting-response label Jan 8, 2018

tombuildsstuff added this to the Future milestone Jan 8, 2018

tombuildsstuff mentioned this pull request Jan 8, 2018

New Data Source: azurerm_app_service_plan #668

Merged

Junyi Yi added 4 commits January 9, 2018 16:13

Mitigate the default and user-defined AppSettings update issue.

d33cff0

Update EndpointSuffix part of the storage primary and secondary conne…

8e92273

…ction string.

Add test of updating Function App version.

5c38bae

Update Function App documentation according to pull request.

eb8a625

JunyiYi removed the waiting-response label Jan 10, 2018

tombuildsstuff modified the milestones: Future, 1.0.2 Jan 10, 2018

tombuildsstuff added 2 commits January 11, 2018 14:09

Documenting Import support for Function Apps

ce731b3

Adding an Import test

a7ccef6

tombuildsstuff approved these changes Jan 11, 2018

View reviewed changes

Making storage connection strings sensitive

8185aa6

tombuildsstuff modified the milestones: 1.0.2, 1.0.1 Jan 11, 2018

Adding acceptance tests covering app settings + tags

afcdaac

tombuildsstuff merged commit 870709c into master Jan 11, 2018

tombuildsstuff deleted the rm_functions_app branch January 11, 2018 16:01

tombuildsstuff added a commit that referenced this pull request Jan 11, 2018

Updating to include #647

ac87eda

tombuildsstuff mentioned this pull request Jan 12, 2018

Feature Request: Azure Functions #131

Closed

ghost locked and limited conversation to collaborators Apr 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_function_app` #647

New Resource: `azurerm_function_app` #647

JunyiYi commented Dec 22, 2017

tombuildsstuff left a comment

tombuildsstuff Jan 6, 2018

tombuildsstuff Jan 6, 2018

tombuildsstuff Jan 6, 2018

JunyiYi Jan 10, 2018

tombuildsstuff Jan 6, 2018

tombuildsstuff Jan 8, 2018

tombuildsstuff Jan 8, 2018

tombuildsstuff Jan 8, 2018

tombuildsstuff Jan 8, 2018

tombuildsstuff Jan 8, 2018

tombuildsstuff Jan 8, 2018

JunyiYi Jan 10, 2018

tombuildsstuff left a comment •

edited

Loading

tombuildsstuff Jan 11, 2018

tombuildsstuff Jan 11, 2018

tombuildsstuff Jan 11, 2018

tombuildsstuff Jan 11, 2018

tombuildsstuff Jan 11, 2018

tombuildsstuff commented Jan 11, 2018

tombuildsstuff commented Jan 11, 2018

tombuildsstuff commented Jan 11, 2018

ghost commented Apr 1, 2020


		* `name` - (Required) Specifies the name of the Azure Functions service. Changing this forces a new resource to be created.

		* `resource_group_name` - (Required) The name of the resource group in which to create the Azure Functions service.


		The following arguments are supported:

		* `name` - (Required) Specifies the name of the Azure Functions service. Changing this forces a new resource to be created.


		* `id` - The ID of the Function App

		* `default_hostname` - The default hostname associated with the Function App - such as `mysite.azurewebsites.net`


		* `app_settings` - (Optional) A key-value pair of App Settings.

		* `enabled` - (Optional) Is the Azure Function service enabled? Changing this forces a new resource to be created.

New Resource: azurerm_function_app #647

New Resource: azurerm_function_app #647

Conversation

JunyiYi commented Dec 22, 2017

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff commented Jan 11, 2018

tombuildsstuff commented Jan 11, 2018

tombuildsstuff commented Jan 11, 2018

ghost commented Apr 1, 2020

New Resource: `azurerm_function_app` #647

New Resource: `azurerm_function_app` #647

tombuildsstuff left a comment •

edited

Loading