Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alter identity_id check to be non-empty #3195

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

Lucretius
Copy link
Contributor

Fixes a bug I introduced in #3183. Big thanks for the catch by @adamday2 - I have fixed the validation to just check for non-zero values. I did not see an existing check for an exact resource ID regex - something to consider at a later date I suppose.

@ghost ghost added the size/XS label Apr 5, 2019
@katbyte katbyte added this to the v1.25.0 milestone Apr 5, 2019
@katbyte
Copy link
Collaborator

katbyte commented Apr 5, 2019

Thanks for the speedy fix @Lucretius, LGTM 👍

@katbyte katbyte merged commit af963d1 into hashicorp:master Apr 5, 2019
@Lucretius Lucretius deleted the fix-vm-identity-check branch April 5, 2019 17:49
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants