-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validation for identity_ids #3183
validation for identity_ids #3183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @Lucretius
Is this validating that it is a UUID? I was under the impression that this field took in a resource ID of the format: "/subscriptions/{subscription_id}/resourcegroups/{resource_group}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/" When attempting to use a UUID, I get this error:
|
Hmm the tests seemed to be checking for a UUID, if this is incorrect I can swap this to a less strict “not empty” check. Definitely don’t want to break this! Yeah looks like I had been checking the generated principal ID and not the id of the user assigned identity - ill see if I can edit the acceptance test to verify |
This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.25.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Resolves #3059
identity_ids
is still optional, but now if it is specified it mustNot sure if there is another option for this field aside from UUIDs - but if not, we can create a stronger validation checking that all entries are UUIDs.