Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Riviera SDK [Part 1 of 2] #289

Merged
merged 21 commits into from
Aug 30, 2017
Merged

Removing Riviera SDK [Part 1 of 2] #289

merged 21 commits into from
Aug 30, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Aug 30, 2017

This PR supersedes the work done by @sebastus in PR's #191 / #190 / #178 - and fully removes the Riviera Client from the codebase. A second PR will migrate the azure.String methods into the Provider

Tasks:

Fixes #255 #49 #93

@tombuildsstuff tombuildsstuff changed the title [WIP] Removing Riviera SDK [Part 1 of 2] Removing Riviera SDK [Part 1 of 2] Aug 30, 2017
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Aug 30, 2017

Ran the entire test suite and this looks good:

screen shot 2017-08-30 at 14 45 07

The test failures are unrelated connection drops - which we'll get to in a bit.

@tombuildsstuff tombuildsstuff merged commit 55aeae4 into master Aug 30, 2017
@tombuildsstuff tombuildsstuff deleted the removing-riviera branch August 30, 2017 13:54
tombuildsstuff added a commit that referenced this pull request Aug 30, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants