azurerm_spring_cloud_gateway - split to create/update functions
#24116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
requested changes
Dec 5, 2023
| existing, err := client.Get(ctx, id.ResourceGroup, id.SpringName, id.GatewayName) | ||
| if err != nil { | ||
| if !utils.ResponseWasNotFound(existing.Response) { | ||
| return fmt.Errorf("checking for existing %s: %+v", id, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("checking for existing %s: %+v", id, err) | |
| return fmt.Errorf("retrieving %s: %+v", id, err) |
Comment on lines
401
to
411
| if utils.ResponseWasNotFound(existing.Response) { | ||
| return fmt.Errorf("retreiving %s: resource was not found", id) | ||
| } | ||
|
|
||
| if existing.Properties == nil { | ||
| return fmt.Errorf("retreiving %s: properties was nil", id) | ||
| } | ||
| properties := existing.Properties | ||
|
|
||
| if existing.Sku == nil { | ||
| return fmt.Errorf("retreiving %s: sku was nil", id) |
Comment on lines
462
to
467
| return fmt.Errorf("creating/updating %s: %+v", id, err) | ||
| } | ||
|
|
||
| if err := future.WaitForCompletionRef(ctx, client.Client); err != nil { | ||
| return fmt.Errorf("waiting for creation/update of %s: %+v", id, err) | ||
| } |
There was a problem hiding this comment.
Please update the error messages in the create as well
Suggested change
| return fmt.Errorf("creating/updating %s: %+v", id, err) | |
| } | |
| if err := future.WaitForCompletionRef(ctx, client.Client); err != nil { | |
| return fmt.Errorf("waiting for creation/update of %s: %+v", id, err) | |
| } | |
| return fmt.Errorf("updating %s: %+v", id, err) | |
| } | |
| if err := future.WaitForCompletionRef(ctx, client.Client); err != nil { | |
| return fmt.Errorf("waiting for update of %s: %+v", id, err) | |
| } |
|
Hi @stephybun , Thanks for the code review! I've updated this PR as suggested, please take another look. |
stephybun
requested changes
Dec 6, 2023
Comment on lines
402
to
406
| return fmt.Errorf("retreiving %s: resource was not found", id) | ||
| } | ||
|
|
||
| if existing.Properties == nil { | ||
| return fmt.Errorf("retreiving %s: properties was nil", id) |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.