Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_spring_cloud_gateway - use pandora SDK #23998

Closed
wants to merge 3 commits into from
Closed

azurerm_spring_cloud_gateway - use pandora SDK #23998

wants to merge 3 commits into from

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Nov 23, 2023 •
edited
Loading

image

magodo
magodo requested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I have left some additional mostly minor comments that once addressed this should be good to merge 👍

internal/services/springcloud/spring_cloud_gateway_resource.go Outdated Show resolved Hide resolved
internal/services/springcloud/spring_cloud_gateway_resource.go Show resolved Hide resolved
internal/services/springcloud/spring_cloud_gateway_resource.go Outdated Show resolved Hide resolved
jackofallops
jackofallops requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ms-henglu
Thanks for this PR, however, we'll need this PR to be split into stages. The description only calls out using the Pandora SDK, however, there are significant other changes in the resource. The split of create/update, and the change to Typed resource need to be separated our into their own PRs, in that order. If you can take a look at that, we can get this moving.

Thanks

@ms-henglu
Copy link
Contributor Author

#24116

@ms-henglu ms-henglu closed this Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops requested changes

@magodo magodo magodo requested changes

Assignees
No one assigned
Labels
refactor service/spring size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-henglu @magodo @jackofallops