Support for TCP type & ExposedPort on `azurerm_container_app` #23752

SpartakusMd · 2023-11-01T08:06:17Z

Added the missing doc that TCP type is supported. Result of containerapps: updating to API Version 2023-05-01 #22804
Added missing option for ExposedPort
GO Azure SDK https://github.com/hashicorp/go-azure-sdk/blob/main/resource-manager/containerapps/2023-05-01/containerapps/model_ingress.go

stephybun

Thanks for this PR @SpartakusMd.

Overall this looks good, but the test needs to be updated to use the config that you added in this PR and the documentation would also need an update.

Once that's done I can run the test and see if we can get this merged.

internal/services/containerapps/container_app_resource_test.go

stephybun

New test failure 🙃 - I'm no SME on ContainerApps so I'm not sure how specific the configuration will need to be in order to use exposed_port or how much validation we should be putting into the resource to prevent users from running into this kind of error.

@jackofallops perhaps you could provide a little bit of guidance here?

------- Stdout: -------
=== RUN   TestAccContainerAppResource_completeTcpExposedPort
=== PAUSE TestAccContainerAppResource_completeTcpExposedPort
=== CONT  TestAccContainerAppResource_completeTcpExposedPort
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: creating Container App (Subscription: "*******"
        Resource Group Name: "acctestRG-CAEnv-231101121940949762"
        Container App Name: "acctest-capp-231101121940949762"): performing CreateOrUpdate: containerapps.ContainerAppsClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="ContainerAppTcpRequiresVnet" Message="Applications with external TCP ingress can only be deployed to Container App Environments that have a custom VNET. Set ingress traffic to 'Limited to Container Apps Environment' if you want to deploy to a Container App Environment without a custom VNET. For more information on custom VNETs, please visit https://go.microsoft.com/fwlink/?linkid=2238174
          with azurerm_container_app.test,
          on terraform_plugin_test.tf line 130, in resource "azurerm_container_app" "test":
         130: resource "azurerm_container_app" "test" {
        creating Container App (Subscription: "*******"
        Resource Group Name: "acctestRG-CAEnv-231101121940949762"
        Container App Name: "acctest-capp-231101121940949762"): performing
        CreateOrUpdate: containerapps.ContainerAppsClient#CreateOrUpdate: Failure
        sending request: StatusCode=0 -- Original Error:
        Code="ContainerAppTcpRequiresVnet" Message="Applications with external TCP
        ingress can only be deployed to Container App Environments that have a custom
        VNET. Set ingress traffic to 'Limited to Container Apps Environment' if you
        want to deploy to a Container App Environment without a custom VNET. For more
        information on custom VNETs, please visit
        https://go.microsoft.com/fwlink/?linkid=2238174
--- FAIL: TestAccContainerAppResource_completeTcpExposedPort (1162.14s)
FAIL

jackofallops · 2023-11-01T13:19:24Z

New test failure 🙃 - I'm no SME on ContainerApps so I'm not sure how specific the configuration will need to be in order to use exposed_port or how much validation we should be putting into the resource to prevent users from running into this kind of error.

@jackofallops perhaps you could provide a little bit of guidance here?

@SpartakusMd / @stephybun - The config is missing a user defined subnet to attach to the Container App Environment, using templateWithVnet in place of templatePlusExtras I think will resolve that. fwiw, a lot of the config in the completeTcpExposedPort test can be removed as it only needs to test the new property / ingress block (e.g. the extended container config for probes and volumes, since they're unrelated to the change and provide no additional benefit here)

SpartakusMd · 2023-11-01T14:00:21Z

Switched to use templateWithVnet and did some cleanup. Hopefully it's enough 🤞 But I believe it needs infrastructure_subnet_id on the azurerm_container_app_environment but it's missing. Am I rigth?

If it will fail again the test, I will another app environment with everything necessary for the Vnet.

stephybun

@SpartakusMd third times a charm - test passed! 🎉

Just need to fix up the terraform linting that the GitHub Action is flagging then this should be good to go!

SpartakusMd · 2023-11-02T07:30:53Z

@stephybun perfect. Fixed the linting too.

stephybun

Thanks @SpartakusMd LGTM 💯

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.77.0" to "3.79.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.79.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.79.0
ENHANCEMENTS:

* provider: log instead of error when RPs are unavailable when validating RP registrations ([#23380](hashicorp/terraform-provider-azurerm#23380 `azurerm_arc_kuberenetes_cluster_extension_resource` - the `version` and `release_train` properties can now be set simultaneously ([#23692](hashicorp/terraform-provider-azurerm#23692 `azurerm_container_apps` - support for the `ingress.exposed_port` property ([#23752](hashicorp/terraform-provider-azurerm#23752 `azurerm_cosmosdb_postgresql_cluster` - read replica clusters can be created without specifying `administrator_login_password` property ([#23750](hashicorp/terraform-provider-azurerm#23750 `azurerm_managed_application` - arrays can be supplied in the `parameter_values` property ([#23754](hashicorp/terraform-provider-azurerm#23754 `azurerm_storage_management_policy` - support for properties `rule.*.actions.*.base_blob.0.tier_to_cold_after_days_since_{modification|last_access_time|creation}_greater_than and rule.*.actions.*.{snapshot|version}.0.tier_to_cold_after_days_since_creation_greater_than` ([#23574](https://github.com/hashicorp/terraform-provider-azurerm/issues/23574))

BUG FIXES:

* `azurerm_api_management_diagnostic` - the `operation_name_format` attribute will only be sent if `identifier` is set to `applicationinsights` ([#23736](hashicorp/terraform-provider-azurerm#23736 `azurerm_backup_policy_vm` - fix payload by using current datetime ([#23586](hashicorp/terraform-provider-azurerm#23586 `azurerm_kubernetes_cluster` - the `custom_ca_trust_certificates_base64` property can not be removed, only updated ([#23737](https://github.com/hashicorp/terraform-provider-azurerm/issues/23737))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-05-09T02:10:07Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Support for TCP type & ExposedPort on azurerm_container_app

9d640fe

github-actions bot added service/container-apps size/M labels Nov 1, 2023

SpartakusMd marked this pull request as draft November 1, 2023 09:45

fix ingress

9052fe6

SpartakusMd marked this pull request as ready for review November 1, 2023 10:32

stephybun requested changes Nov 1, 2023

View reviewed changes

internal/services/containerapps/container_app_resource_test.go Outdated Show resolved Hide resolved

stephybun added the enhancement label Nov 1, 2023

github-actions bot added the waiting-response label Nov 1, 2023

fix test

e0c8b34

github-actions bot added waiting-response and removed waiting-response labels Nov 1, 2023

remove allow_insecure_connections from tcp test

95ae059

github-actions bot removed the waiting-response label Nov 1, 2023

documentation

47db1e3

github-actions bot added the documentation label Nov 1, 2023

stephybun reviewed Nov 1, 2023

View reviewed changes

github-actions bot added the waiting-response label Nov 1, 2023

vnet fix

05d620b

github-actions bot removed the waiting-response label Nov 1, 2023

github-actions bot added the waiting-response label Nov 2, 2023

stephybun reviewed Nov 2, 2023

View reviewed changes

fix spacing

03ddc58

github-actions bot removed the waiting-response label Nov 2, 2023

stephybun approved these changes Nov 2, 2023

View reviewed changes

stephybun merged commit 233c40d into hashicorp:main Nov 2, 2023
23 checks passed

github-actions bot added this to the v3.79.0 milestone Nov 2, 2023

SpartakusMd deleted the feature/Support-for-ExposedPort-on-azurerm_container_app branch November 2, 2023 08:07

stephybun added a commit that referenced this pull request Nov 2, 2023

Update for #23737 #23736 #23752 #23750 #23754

6d31fca

This was referenced Nov 3, 2023

azurerm_container_app - Ingress type TCP support #21133

Open

Container apps missing parameters #22755

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for TCP type & ExposedPort on `azurerm_container_app` #23752

Support for TCP type & ExposedPort on `azurerm_container_app` #23752

SpartakusMd commented Nov 1, 2023 •

edited

Loading

stephybun left a comment

stephybun left a comment

jackofallops commented Nov 1, 2023

SpartakusMd commented Nov 1, 2023 •

edited

Loading

stephybun left a comment

SpartakusMd commented Nov 2, 2023 •

edited

Loading

stephybun left a comment

github-actions bot commented May 9, 2024

Support for TCP type & ExposedPort on azurerm_container_app #23752

Support for TCP type & ExposedPort on azurerm_container_app #23752

Conversation

SpartakusMd commented Nov 1, 2023 • edited Loading

stephybun left a comment

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

jackofallops commented Nov 1, 2023

SpartakusMd commented Nov 1, 2023 • edited Loading

stephybun left a comment

Choose a reason for hiding this comment

SpartakusMd commented Nov 2, 2023 • edited Loading

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented May 9, 2024

Support for TCP type & ExposedPort on `azurerm_container_app` #23752

Support for TCP type & ExposedPort on `azurerm_container_app` #23752

SpartakusMd commented Nov 1, 2023 •

edited

Loading

SpartakusMd commented Nov 1, 2023 •

edited

Loading

SpartakusMd commented Nov 2, 2023 •

edited

Loading