Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapps: updating to API Version 2023-05-01 #22804

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR upgrades containerapps to use API Version 2023-05-01 rather than 2022-03-01 - which supersedes #22476 and will enable #21133 to be fixed

Dependent on #22803

@tombuildsstuff
Copy link
Contributor Author

Looks like this API may not be fully rolled out just yet:

 Error: creating Managed Environment (Subscription: "*******"
        Resource Group Name: "acctestRG-CAEnv-230803102145526598"
        Managed Environment Name: "acctest-CAEnv230803102145526598"): performing CreateOrUpdate: managedenvironments.ManagedEnvironmentsClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westeurope' and API version '2023-05-01' for type 'managedEnvironments'. The supported api-versions are '2022-01-01-preview, 2022-03-01, 2022-06-01-preview, 2022-10-01, 2022-11-01-preview, 2023-04-01-preview'

Whilst the Stable API Version has been merged into main, it's in neither the Go SDK or the .net SDK - so this is probably waiting on the API to be fully rolled out

@tombuildsstuff tombuildsstuff added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Aug 3, 2023
@tombuildsstuff tombuildsstuff removed this from the v3.68.0 milestone Aug 3, 2023
@jkrilov
Copy link
Contributor

jkrilov commented Aug 3, 2023

Can we reopen the other PR with the preview API? Or do you think this will be resolved quickly?

@rcskosir rcskosir mentioned this pull request Aug 3, 2023
1 task
@Phiph
Copy link

Phiph commented Aug 4, 2023

Looks like this API may not be fully rolled out just yet:

 Error: creating Managed Environment (Subscription: "*******"
        Resource Group Name: "acctestRG-CAEnv-230803102145526598"
        Managed Environment Name: "acctest-CAEnv230803102145526598"): performing CreateOrUpdate: managedenvironments.ManagedEnvironmentsClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westeurope' and API version '2023-05-01' for type 'managedEnvironments'. The supported api-versions are '2022-01-01-preview, 2022-03-01, 2022-06-01-preview, 2022-10-01, 2022-11-01-preview, 2023-04-01-preview'

Whilst the Stable API Version has been merged into main, it's in neither the Go SDK or the .net SDK - so this is probably waiting on the API to be fully rolled out

Hey @tombuildsstuff is there anything I can do to run this test to see when it's been made GA?

It looks as though MS haven't updated their changeling yet to include that API version.

https://learn.microsoft.com/en-us/azure/templates/microsoft.app/change-log/managedenvironments

@Phiph
Copy link

Phiph commented Aug 9, 2023

There's a new Api revision that supports Multiple Ports which is very useful for many people under 2023-05-02-preview

microsoft/azure-container-apps#763 (comment)

@tombuildsstuff
Copy link
Contributor Author

@Phiph looks like this Stable API Version is now available (per the docs site): https://learn.microsoft.com/en-us/azure/templates/microsoft.app/change-log/managedenvironments

Will run the tests to confirm that's been fully rolled out now..

@Phiph
Copy link

Phiph commented Aug 10, 2023

Legend! Thanks Tom

@tombuildsstuff tombuildsstuff marked this pull request as ready for review August 10, 2023 09:59
@tombuildsstuff tombuildsstuff modified the milestones: v3.69.0, v3.70.0 Aug 10, 2023
@tiwood
Copy link
Contributor

tiwood commented Aug 22, 2023

@tombuildsstuff we too would like to deploy Container Apps with the latest API version. If I understood correctly this here could be merged now?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍽️

@tombuildsstuff tombuildsstuff modified the milestones: v3.70.0, v3.72.0 Aug 31, 2023
@tombuildsstuff tombuildsstuff removed the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Aug 31, 2023
@tombuildsstuff tombuildsstuff merged commit 37fdea8 into main Aug 31, 2023
@tombuildsstuff tombuildsstuff deleted the f/updating-containerapps-to-2023-05-01 branch August 31, 2023 11:02
@tombuildsstuff
Copy link
Contributor Author

Tests look good 👍

tombuildsstuff added a commit that referenced this pull request Aug 31, 2023
@jkrilov
Copy link
Contributor

jkrilov commented Aug 31, 2023

Just in time for a slew of other ACA updates that went GA yesterday. Should be very helpful. Thanks!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants