Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - Add support for OMS MSI authentication #20757

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

EppO
Copy link
Contributor

@EppO EppO commented Mar 2, 2023

@EppO EppO changed the title azurerm_kubernetes_cluster - Add support for OMS MSI authentication azurerm_kubernetes_cluster - Add support for OMS MSI authentication Mar 3, 2023
@stephybun stephybun self-assigned this Mar 6, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @EppO - looks like there is a tes failure:

est ended in panic.

------- Stdout: -------
=== RUN   TestAccKubernetesCluster_addonProfileOMSToggle
=== PAUSE TestAccKubernetesCluster_addonProfileOMSToggle
=== CONT  TestAccKubernetesCluster_addonProfileOMSToggle

------- Stderr: -------
panic: oms_agent.0.msi_auth_for_monitoring_enabled: '' expected type 'bool', got unconvertible type 'string', value: 'false'

goroutine 376 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc001c3cd00, {0x6e3ff14, 0x9}, {0x60f0fe0, 0xc002b30480})

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @EppO. I left a few minor comments but once those are fixed up this should be good to go!

website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
internal/services/containers/kubernetes_addons.go Outdated Show resolved Hide resolved
- Transform string into boolean from Azure API result
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EppO - tests look good, just two minor comments then this should be good to merge.

Co-authored-by: stephybun <[email protected]>
@EppO
Copy link
Contributor Author

EppO commented Mar 9, 2023

Thanks @EppO - tests look good, just two minor comments then this should be good to merge.

Did the changes you suggested, do I need to rebase my branch?

@EppO EppO requested review from stephybun and removed request for katbyte March 9, 2023 14:30
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EppO LGTM 🍉

@stephybun stephybun merged commit 1e6092f into hashicorp:main Mar 9, 2023
@github-actions github-actions bot added this to the v3.47.0 milestone Mar 9, 2023
stephybun added a commit that referenced this pull request Mar 9, 2023
@EppO EppO deleted the add-oms-msi-auth branch March 9, 2023 16:34
@EppO
Copy link
Contributor Author

EppO commented Mar 9, 2023

Thanks @EppO LGTM 🍉

Thanks for your guidance @stephybun, really appreciated

@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for managed identity authentication for AKS monitoring add-on
3 participants