-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster
- Add support for OMS MSI authentication
#20757
Conversation
azurerm_kubernetes_cluster
- Add support for OMS MSI authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @EppO - looks like there is a tes failure:
est ended in panic.
------- Stdout: -------
=== RUN TestAccKubernetesCluster_addonProfileOMSToggle
=== PAUSE TestAccKubernetesCluster_addonProfileOMSToggle
=== CONT TestAccKubernetesCluster_addonProfileOMSToggle
------- Stderr: -------
panic: oms_agent.0.msi_auth_for_monitoring_enabled: '' expected type 'bool', got unconvertible type 'string', value: 'false'
goroutine 376 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc001c3cd00, {0x6e3ff14, 0x9}, {0x60f0fe0, 0xc002b30480})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @EppO. I left a few minor comments but once those are fixed up this should be good to go!
Co-authored-by: stephybun <[email protected]>
- Transform string into boolean from Azure API result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EppO - tests look good, just two minor comments then this should be good to merge.
Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
Did the changes you suggested, do I need to rebase my branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EppO LGTM 🍉
Thanks for your guidance @stephybun, really appreciated |
This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Enable support for MSI authentication for OMS agent (https://learn.microsoft.com/en-us/azure/azure-monitor/containers/container-insights-enable-aks?tabs=azure-cli#migrate-to-managed-identity-authentication)
closes #20725