Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - allow resizing of default_node_pool #20628

Merged
merged 17 commits into from
Mar 9, 2023

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Feb 23, 2023

Closes #7093
image

@github-actions github-actions bot added size/L and removed size/XL labels Feb 23, 2023
@github-actions github-actions bot added size/XL and removed size/L labels Feb 24, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments LGTM ☔

internal/services/containers/kubernetes_nodepool.go Outdated Show resolved Hide resolved
@alexkrebiehlKR
Copy link

Would it make sense for the provider to generate a temporary name by default? Needing to specify the temporary name to make the provider behave as you’d expect (i.e. don’t destroy the cluster when resizing) seems like an opportunity for users to accidentally destroy their cluster if they don’t know that setting exists or what it does.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment around the naming for this field, since this is likely to be used for other fields in the future - but this otherwise LGTM 👍

internal/services/containers/kubernetes_nodepool.go Outdated Show resolved Hide resolved
@stephybun stephybun merged commit 1cafb6b into main Mar 9, 2023
@stephybun stephybun deleted the f/aks-update-def-node-pool-vmsize branch March 9, 2023 15:12
@github-actions github-actions bot added this to the v3.47.0 milestone Mar 9, 2023
stephybun added a commit that referenced this pull request Mar 9, 2023
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants