Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK: updating DNS, Maps and SignalR to use the new base layer from hashicorp/go-azure-sdk #20688

Merged
merged 7 commits into from
Feb 28, 2023
Merged

SDK: updating DNS, Maps and SignalR to use the new base layer from hashicorp/go-azure-sdk #20688

merged 7 commits into from
Feb 28, 2023

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Feb 28, 2023 •
edited
Loading

This PR updates the Services for DNS, Maps and SignalR to use the new base layer from hashicorp/go-azure-sdk, and also updates hashicorp/go-azure-sdk to v0.20230228.1160358.

Associated changelog:

* dependencies: updating to `v0.20230228.1160358` of `github.com/hashicorp/go-azure-sdk` [GH-20688]
* `dns`: refactoring to use `hashicorp/go-azure-sdk` as a base layer rather than `Azure/go-autorest` [GH-20688]
* `maps`: refactoring to use `hashicorp/go-azure-sdk` as a base layer rather than `Azure/go-autorest` [GH-20688]
* `signalr`: refactoring to use `hashicorp/go-azure-sdk` as a base layer rather than `Azure/go-autorest` [GH-20688]

@tombuildsstuff tombuildsstuff requested review from mbfrahry and removed request for mbfrahry February 28, 2023 07:26
@tombuildsstuff tombuildsstuff marked this pull request as draft February 28, 2023 07:26
@tombuildsstuff tombuildsstuff self-assigned this Feb 28, 2023
@tombuildsstuff tombuildsstuff added this to the v3.46.0 milestone Feb 28, 2023
@tombuildsstuff tombuildsstuff force-pushed the dependencies/go-azure-sdk branch from 885dbd2 to aab76d2 Compare February 28, 2023 08:47
@hashicorp hashicorp deleted a comment from github-actions bot Feb 28, 2023
@hashicorp hashicorp deleted a comment from github-actions bot Feb 28, 2023
@tombuildsstuff tombuildsstuff mentioned this pull request Feb 28, 2023
Merged
@tombuildsstuff
Copy link
Contributor Author

Dependent on hashicorp/go-azure-sdk#339

@tombuildsstuff
Copy link
Contributor Author

Maps tests pass:

Screenshot 2023-02-28 at 17 59 58

@tombuildsstuff tombuildsstuff marked this pull request as ready for review February 28, 2023 17:00
@tombuildsstuff tombuildsstuff requested a review from a team February 28, 2023 17:01
jackofallops
jackofallops approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Request/Response Logging is (intentionally) being added in a follow up PR

@tombuildsstuff tombuildsstuff merged commit cbe804c into main Feb 28, 2023
@tombuildsstuff tombuildsstuff deleted the dependencies/go-azure-sdk branch February 28, 2023 17:26
tombuildsstuff added a commit that referenced this pull request Feb 28, 2023
@tombuildsstuff
updating to include #20688
e878072
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This functionality has been released in v3.46.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@phatcher phatcher mentioned this pull request Mar 9, 2023
Closed
1 task
@dduportal dduportal mentioned this pull request Mar 21, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees

@tombuildsstuff tombuildsstuff

Labels
dependencies service/dns service/maps service/signalr size/XL
Projects
None yet
Milestone
v3.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @jackofallops