Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: updating the pollers for resourcemanager #339

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Conversation

tombuildsstuff
Copy link
Contributor

This PR fixes a number of issues identified when enabling the base layer in hashicorp/terraform-provider-azurerm#20688, namely:

  1. Some Resource Manager APIs return the LRO OperationStatus URI on a verbose hostname (including the port), such that the check we have present here isn't strictly needed (else we fail comparing https://management.azure.com to https://management.azure.com:443, which whilst technically the same the LRO URI isn't guaranteed to be on the same port afaik)
  2. Some Resource Manager APIs (such as SignalR) return an LRO Status of Running rather than InProgress, as such this PR adds an exception for this
  3. Introduces a Delete LRO - which (after deleting a resource) will validate that the resource ultimately disappears

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added the release-once-merged The SDK should be released once this PR is merged label Feb 28, 2023
@tombuildsstuff tombuildsstuff merged commit 611f835 into main Feb 28, 2023
@tombuildsstuff tombuildsstuff deleted the b/polling-uri branch February 28, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants