Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_stream_analytics_output_servicebus_queue: Shared access policy name/key optional for MSI authentication #19712

Merged

Conversation

marcgs
Copy link
Contributor

@marcgs marcgs commented Dec 16, 2022

shared_access_policy_name and shared_access_policy_key parameters made optional as these are not required when authenticationMode is MSI (Managed Service Identity). See analog PR for service bus topics: #19708

This requires the go sdk for stream analytics to be upgraded to version "2021-10-01-preview". This has been initiated in this PR. This has been prepared in PR #20145.

Acceptance tests were adapted and run successfully:

TF_ACC=1 go test -v ./internal/services/streamanalytics -run=TestAccStreamAnalyticsOutputServiceBusQueue -timeout 20m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_avro
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_avro
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_csv
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_csv
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_json
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_json
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_authenticationModeMsi
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_authenticationModeMsi
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_update
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_update
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_requiresImport
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_requiresImport
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_propertyColumns
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_propertyColumns
=== RUN   TestAccStreamAnalyticsOutputServiceBusQueue_systemPropertyColumns
=== PAUSE TestAccStreamAnalyticsOutputServiceBusQueue_systemPropertyColumns
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_avro
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_update
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_csv
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_json
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_authenticationModeMsi
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_propertyColumns
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_systemPropertyColumns
=== CONT  TestAccStreamAnalyticsOutputServiceBusQueue_requiresImport
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_json (442.69s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_avro (446.55s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_csv (448.20s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_authenticationModeMsi (448.84s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_requiresImport (464.29s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_systemPropertyColumns (692.07s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_propertyColumns (698.98s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_update (743.26s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/streamanalytics       744.912s

@katbyte
Copy link
Collaborator

katbyte commented Jan 9, 2023

@marcgs - now that hashicorp/pandora#1946 has been merged is this PR ready to be reviewed/merged?

@marcgs
Copy link
Contributor Author

marcgs commented Jan 21, 2023

Waiting for #20145 to be merged

@marcgs marcgs force-pushed the feature/asa-service-bus-queue-msi-auth branch from f380da0 to 85ce127 Compare January 24, 2023 17:30
@marcgs marcgs marked this pull request as ready for review January 24, 2023 17:41
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcgs - LGTM 🌩️

@katbyte katbyte merged commit 0044121 into hashicorp:main Jan 26, 2023
@github-actions github-actions bot added this to the v3.41.0 milestone Jan 26, 2023
katbyte added a commit that referenced this pull request Jan 26, 2023
@github-actions
Copy link

This functionality has been released in v3.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants