azurerm_stream_analytics_output_servicebus_topic: shared access policy name and key parameters made optional to support MSI authentication

[marcgs]

shared_access_policy_name and shared_access_policy_key parameters made optional as these are not required when authenticationMode is MSI (Managed Service Identity). See analog PR for service bus queues #19712

This requires the go sdk for stream analytics to be upgraded to version "2021-10-01-preview". This has been initiated in this PR. This has been prepared in PR #20145.

Acceptance tests were adapted and run successfully:

TF_ACC=1 go test -v ./internal/services/streamanalytics -run=TestAccStreamAnalyticsOutputServiceBusTopic -timeout 20m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_avro
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_avro
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_csv
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_csv
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_json
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_json
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_propertyColumns
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_propertyColumns
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_update
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_update
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_requiresImport
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_requiresImport
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_authenticationModeMsi
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_authenticationModeMsi
=== RUN   TestAccStreamAnalyticsOutputServiceBusTopic_systemPropertyColumns
=== PAUSE TestAccStreamAnalyticsOutputServiceBusTopic_systemPropertyColumns
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_avro
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_update
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_json
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_authenticationModeMsi
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_csv
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_propertyColumns
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_requiresImport
=== CONT  TestAccStreamAnalyticsOutputServiceBusTopic_systemPropertyColumns
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_csv (300.18s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_json (302.18s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_propertyColumns (302.30s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_requiresImport (322.28s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_avro (361.49s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_authenticationModeMsi (361.87s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_update (433.09s)
--- PASS: TestAccStreamAnalyticsOutputServiceBusTopic_systemPropertyColumns (515.33s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/streamanalytics       517.063s

[ziyeqf]

Hi @marcgs, kindly remind it seems the linked PR in the description may be mismatch.

[marcgs]

Hi @marcgs, kindly remind it seems the linked PR in the description may be mismatch.

Oops... thanks for the hint! Fixed.

[katbyte]

@marcgs - now that hashicorp/pandora#1946 has been merged is this PR ready to be reviewed/merged?

[marcgs]

@marcgs - now that hashicorp/pandora#1946 has been merged is this PR ready to be reviewed/merged?

@katbyte using stream analytics 2021-10-01-preview requires a bunch of additional changes. Should a separate PR be opened to update the vendor directory?

[katbyte]

@marcgs - another pr would be great!

[marcgs]

@marcgs - another pr would be great!

There you go #20145 . Once merged I can open this PR and #19712 as well.

[katbyte]

LGTM ⛈️

[github-actions]

This functionality has been released in v3.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.