Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - adds support for enabling SFTP #19426

Closed
wants to merge 14 commits into from

Conversation

leesutcliffe
Copy link
Contributor

This PR is to add SFTP support to the azurerm_storage_account resource.
A sftp_enabled property has been added which takes a boolean value to enable or disable the service

Relates-to: #14736

Acceptance tests run successfully

make acctests SERVICE=storage TESTARGS='-run=TestAccStorageAccount_isSftpEnabled' TESTTIMEOUT='60m'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/storage -run=TestAccStorageAccount_isSftpEnabled -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStorageAccount_isSftpEnabled
=== PAUSE TestAccStorageAccount_isSftpEnabled
=== CONT  TestAccStorageAccount_isSftpEnabled
--- PASS: TestAccStorageAccount_isSftpEnabled (190.48s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       (cached)

@leesutcliffe
Copy link
Contributor Author

Resubmitting without messing rebase

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants