azurerm_storage_account - fix crash in multichannel checking
#19298
Conversation
| if smb != nil && smb.Multichannel != nil { | ||
|
|
||
| if smb.Multichannel.Enabled != nil { | ||
| if *shareProperties.FileServicePropertiesProperties.ProtocolSettings.Smb.Multichannel.Enabled { | ||
| return fmt.Errorf("`multichannel_enabled` isn't supported for Standard tier Storage accounts") | ||
| } | ||
| } |
There was a problem hiding this comment.
probably could simplify this to:
| if smb != nil && smb.Multichannel != nil { | |
| if smb.Multichannel.Enabled != nil { | |
| if *shareProperties.FileServicePropertiesProperties.ProtocolSettings.Smb.Multichannel.Enabled { | |
| return fmt.Errorf("`multichannel_enabled` isn't supported for Standard tier Storage accounts") | |
| } | |
| } | |
| if smb != nil && smb.Multichannel != nil && smb.Multichannel.Enabled != nil && * smb.Multichannel.Enabled { | |
| return fmt.Errorf("`multichannel_enabled` isn't supported for Standard tier Storage accounts") | |
| } |
There was a problem hiding this comment.
This is dual purpose here, we need to error on *smb.Multichannel.Enabled == true and zero the *smb.Multichannel regardless, hence the split of if conditions, so I think this is correct as is?
There was a problem hiding this comment.
sorry missed this notification - sounds good/works for me
| if smb != nil && smb.Multichannel != nil { | ||
|
|
||
| if smb.Multichannel.Enabled != nil { | ||
| if *shareProperties.FileServicePropertiesProperties.ProtocolSettings.Smb.Multichannel.Enabled { | ||
| return fmt.Errorf("`multichannel_enabled` isn't supported for Standard tier Storage accounts") | ||
| } | ||
| } |
There was a problem hiding this comment.
sorry missed this notification - sounds good/works for me
Relates-to: hashicorp#14736
|
This functionality has been released in v3.33.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #19220