Disable tflint workflow & fix linting

.github/workflows/automation-open-pull-request.yaml

@@ -1,4 +1,6 @@
+---
 name: Open Pull Request when an `auto-pr` is pushed
+
 on:
   push:
     branches:

.github/workflows/depscheck.yaml

@@ -1,23 +1,24 @@
 ---
 name: Vendor Dependencies Check
+
 permissions:
   contents: read
+
 on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '.github/**'
-      - '**.go'
+      - '.github/workflows/depscheck.yaml'
       - 'vendor/**'
-      - '.github/workflows/**'
+      - '**.go'
 
 jobs:
   depscheck:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-         go-version: '1.19.3'
+          go-version-file: .go-version
       - run: bash scripts/gogetcookie.sh
       - run: make depscheck

.github/workflows/gencheck.yaml

@@ -1,27 +1,27 @@
 ---
 name: Generation Check
+
 permissions:
   contents: read
+
 on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '.github/**'
+      - '.github/workflows/gencheck.yaml'
       - '**.go'
-      - 'azurerm/**'
-      - '.github/workflows/**'
 
 concurrency:
   group: 'gencheck-${{ github.head_ref }}'
   cancel-in-progress: true
 
 jobs:
   gencheck:
-    runs-on: ubuntu-latest
+    runs-on: [custom, linux, large]
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
+          go-version-file: .go-version
       - run: bash scripts/gogetcookie.sh
       - run: make gencheck

.github/workflows/golint.yaml

@@ -1,29 +1,30 @@
 ---
 name: GoLang Linting
+
 permissions:
   contents: read
+
 on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '.github/**'
-      - '**.go'
+      - '.github/workflows/golint.yaml'
       - 'vendor/**'
-      - '.github/workflows/**'
+      - '**.go'
 
 concurrency:
   group: 'golint-${{ github.head_ref }}'
   cancel-in-progress: true
 
 jobs:
   golint:
-    runs-on: ubuntu-latest
+    runs-on: [custom, linux, large]
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
-      - uses: golangci/golangci-lint-action@v2
+          go-version-file: .go-version
+      - uses: golangci/golangci-lint-action@v3
         with:
-          version: 'v1.45.0'
+          version: 'v1.50.1'
           args: -v

.github/workflows/gradually-deprecated.yaml

@@ -1,12 +1,14 @@
 ---
 name: Check for new usages of deprecated functionality
+
 permissions:
   contents: read
+
 on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '.github/**'
+      - '.github/workflows/gradually-deprecated.yaml'
       - '**.go'
 
 jobs:
@@ -16,7 +18,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
+          go-version-file: .go-version
       - run: ./scripts/run-gradually-deprecated.sh

.github/workflows/issue-comment-created.yaml

@@ -1,3 +1,4 @@
+---
 name: Issue Comment Created Triage
 
 on:
@@ -26,6 +27,7 @@ jobs:
         with:
           github_token: "${{ secrets.GITHUB_TOKEN }}"
           labels: waiting-response
+
   pull_request_comment:
     runs-on: ubuntu-latest
     if: github.event.issue.pull_request && endsWith(github.event.comment.body, '/wr')

.github/workflows/issue-opened.yaml

@@ -1,3 +1,4 @@
+---
 name: Issue Opened Triage
 
 permissions:

.github/workflows/link-milestone.yaml

@@ -1,5 +1,6 @@
 ---
 name: Link Milestone
+
 on:
   pull_request_target:
     branches: [main]
@@ -14,9 +15,9 @@ jobs:
       pull-requests: write
       issues: write
     steps:
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
+          go-version-file: .go-version
       - run: |
           go install github.com/stephybun/link-milestone@latest
           link-milestone

.github/workflows/lock.yaml

@@ -1,3 +1,4 @@
+---
 name: 'Lock Threads'
 
 on:

.github/workflows/milestone-closed.yaml

@@ -1,3 +1,4 @@
+---
 name: Closed Milestones
 
 on:

.github/workflows/pull-request.yaml

@@ -1,3 +1,4 @@
+---
 name: "Pull Request Triage"
 
 permissions:

.github/workflows/release.yml → .github/workflows/release.yaml

@@ -1,3 +1,4 @@
+---
 name: Release
 
 on:
@@ -9,14 +10,6 @@ permissions:
   contents: write
 
 jobs:
-  go-version:
-    runs-on: ubuntu-latest
-    outputs:
-      version: ${{ steps.go-version.outputs.version }}
-    steps:
-      - uses: actions/checkout@v3
-      - id: go-version
-        run: echo "::set-output name=version::$(cat ./.go-version)"
   release-notes:
     runs-on: ubuntu-latest
     steps:
@@ -30,10 +23,11 @@ jobs:
           name: release-notes
           path: release-notes.txt
           retention-days: 1
+
   terraform-provider-release:
     name: 'Terraform Provider Release'
     needs: [go-version, release-notes]
-    uses: hashicorp/ghaction-terraform-provider-release/.github/workflows/hashicorp.yml@v2
+    uses: manicminer/ghaction-terraform-provider-release/.github/workflows/hashicorp.yml@1dba3fa320b576c92d2206c9514e5f9622730010
     secrets:
       hc-releases-github-token: '${{ secrets.HASHI_RELEASES_GITHUB_TOKEN }}'
       hc-releases-host-staging: '${{ secrets.HC_RELEASES_HOST_STAGING }}'
@@ -48,6 +42,6 @@ jobs:
       goreleaser-release-args: --timeout 2h
       hc-releases-aws-role-duration-seconds: 7200
       release-notes: true
-      setup-go-version: '${{ needs.go-version.outputs.version }}'
+      setup-go-version-file: .go-version
       # Product Version (e.g. v1.2.3 or github.ref_name)
       product-version: '${{ github.ref_name }}'

.github/workflows/teamcity-test.yaml

@@ -8,10 +8,10 @@ on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
+      - '.github/workflows/teamcity-test.yaml'
       - '!.teamcity/components/generated/**'
       - '!.teamcity/target/**'
       - '.teamcity/**'
-      - '.github/workflows/**'
 
 concurrency:
   group: 'tctest-${{ github.head_ref }}'
@@ -22,11 +22,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-java@v1
+      - uses: actions/setup-java@v2
         with:
-          java-version: '11'
+          distribution: zulu
+          java-version: 11
           java-package: jdk
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}

.github/workflows/tflint.yaml

@@ -8,10 +8,9 @@ on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '.github/**'
-      - '**.go'
+      - '.github/workflows/tflint.yaml'
       - 'vendor/**'
-      - '.github/workflows/**'
+      - '**.go'
 
 concurrency:
   group: 'tflint-${{ github.head_ref }}'
@@ -20,11 +19,12 @@ concurrency:
 jobs:
   tflint:
     runs-on: ubuntu-latest
+    if: false # skip until https://github.com/bflad/tfproviderlint/issues/255 is fixed
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
+          go-version-file: .go-version
       - run: bash scripts/gogetcookie.sh
       - run: make tools
       - run: make tflint

.github/workflows/thirty-two-bit.yaml

@@ -9,10 +9,9 @@ on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '.github/**'
-      - '**.go'
+      - '.github/workflows/thirty-two-bit.yaml'
       - 'vendor/**'
-      - '.github/workflows/**'
+      - '**.go'
 
 concurrency:
   group: 'thirtytwo-${{ github.head_ref }}'
@@ -23,8 +22,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
+          go-version-file: .go-version
       - run: bash scripts/gogetcookie.sh
       - run: GOARCH=386 GOOS=linux go build -o 32bitbuild .

.github/workflows/unit-test.yaml

@@ -9,22 +9,22 @@ on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '**.go'
+      - '.github/workflows/unit-test.yaml'
       - 'vendor/**'
-      - '.github/workflows/**'
+      - '**.go'
 
 concurrency:
   group: 'unit-${{ github.head_ref }}'
   cancel-in-progress: true
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: [custom, linux, large]
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
+          go-version-file: .go-version
       - run: bash scripts/gogetcookie.sh
       - run: make test
         env:

.github/workflows/validate-examples.yaml

@@ -9,7 +9,7 @@ on:
   pull_request:
     types: ['opened', 'synchronize']
     paths:
-      - '.github/workflows/**'
+      - '.github/workflows/validate-examples.yaml'
       - 'examples/**'
 
 concurrency:
@@ -18,12 +18,12 @@ concurrency:
 
 jobs:
   website-lint:
-    runs-on: ubuntu-latest
+    runs-on: [custom, linux, large]
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: '1.19.3'
+          go-version-file: .go-version
       - run: bash scripts/gogetcookie.sh
       - run: make tools
       - run: make validate-examples

.github/workflows/website-lint.yaml

@@ -9,17 +9,17 @@ on:
   pull_request:
     types: ["opened", "synchronize"]
     paths:
+      - ".github/workflows/website-lint.yaml"
       - "website/**"
-      - ".github/workflows/**"
 
 jobs:
   website-lint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: actions/setup-go@v2
+      - uses: actions/setup-go@v3
         with:
-          go-version: "1.19.3"
+          go-version-file: .go-version
       - run: bash scripts/gogetcookie.sh
       - run: make tools
       - run: make website-lint