Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tflint workflow & fix linting #19365

Merged
merged 13 commits into from
Dec 8, 2022
Merged

Disable tflint workflow & fix linting #19365

merged 13 commits into from
Dec 8, 2022

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Nov 18, 2022 •
edited
Loading

@manicminer manicminer added this to the v3.33.0 milestone Nov 18, 2022
@manicminer manicminer requested a review from a team November 19, 2022 01:29
tombuildsstuff
tombuildsstuff approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting errors aside this looks great 👍

@tombuildsstuff tombuildsstuff modified the milestones: v3.33.0, v3.34.0 Nov 24, 2022
@katbyte katbyte modified the milestones: v3.34.0, v3.35.0 Dec 2, 2022
@katbyte katbyte self-assigned this Dec 7, 2022
mbfrahry
mbfrahry approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/services/batch/batch_pool.go Outdated Show resolved Hide resolved
internal/services/batch/batch_pool.go Show resolved Hide resolved
internal/services/batch/batch_pool.go Show resolved Hide resolved
internal/services/batch/batch_pool.go Show resolved Hide resolved
@katbyte katbyte changed the title Disable tflint workflow Disable tflint workflow & fix linting Dec 8, 2022
@katbyte katbyte merged commit 7a3afb9 into main Dec 8, 2022
@katbyte katbyte deleted the tests/gha-tflint branch December 8, 2022 17:49
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees

@katbyte katbyte

Labels
service/advisor service/analysis service/api-management service/app-configuration service/app-service service/application-insights service/authorization service/automation service/batch service/blueprints service/bots service/cdn service/cognitive-services service/cosmosdb service/custom-resource-provider service/dashboard service/data-factory service/data-protection service/data-share service/database-migration service/databox-edge service/databricks service/devtestlabs service/digital-twins service/dns service/domain-services service/event-grid EventGrid service/frontdoor service/hdinsight service/healthcare service/hpc-cache service/iot-central service/iot-hub service/iot-time-series service/key-vault Key Vault service/kusto service/load-balancers service/log-analytics service/logic service/logz service/machine-learning service/maintenance service/managed-apps service/management-groups service/media service/monitor service/mssql Microsoft SQL Server service/mysql service/network service/policy service/private-dns-resolver service/recovery-services service/redis service/security-center service/sentinel service/service-bus service/service-fabric service/sql service/storage service/stream-analytics service/subscription service/synapse service/video-analyzer size/M tests
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manicminer @tombuildsstuff @mbfrahry @katbyte