-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_group
: Splitting command
into commands
#1740
Conversation
Tests pass:
|
@@ -121,6 +121,10 @@ The `container` block supports: | |||
|
|||
* `command` - (Optional) A command line to be run on the container. Changing this forces a new resource to be created. | |||
|
|||
~> **NOTE:** The field `command` has been deprecated in favour of `commands` to better match the API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
favour
so british...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And Canadian!
Optional: true, | ||
ForceNew: true, | ||
Computed: true, | ||
Deprecated: "Use `commands` instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these have ConflictsWith
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should - but it’s an unsized list so that’s not possible (and customizeDiff doesn’t handle interpolations, which could be used here - so I don’t see that as a viable approach)
Tests pass after the commit removing crash points:
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Given the following config:
Plan between applied changes from current master -> this PR:
When updating
command
to becommands
:the following plan is generated:
Supersedes #1508