Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/container_group: parse command as sh #1508

Closed
wants to merge 1 commit into from
Closed

resource/container_group: parse command as sh #1508

wants to merge 1 commit into from

Conversation

tharvik
Copy link

@tharvik tharvik commented Jul 6, 2018

container_group.command is a schema.TypeString but on the azure's doc, it is a string[].
The current implementation take the command and split it on " ", and so, disallows having an argument containing a space.
In the long run, it would be best to move to a schema.TypeList, but this PR allows to keep the old schema and for complex command by taking it as a sh expression.

@tombuildsstuff
Copy link
Contributor

hey @tharvik

Thanks for this PR - apologies for the delayed review here!

We've spent a little while mulling over how's best to proceed here - as this PR highlights the command field should really be an array rather than a string which we parse. Given the repository being used to do the parsing of the command had been archived, I've opened #1740 which deprecates the command field in favour of a new commands field (which takes an array to match the API, whilst allowing both to continue working for the moment) - which I'm going to close this PR in favour of, I hope you don't mind!

Thanks!

@tharvik tharvik deleted the parse_cmd_as_sh branch August 9, 2018 07:09
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants