Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect validation of app service sticky setting names #17209

Merged
merged 2 commits into from
Jun 24, 2022
+38 −45
Merged

Remove incorrect validation of app service sticky setting names #17209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcb643f
remove validation of app service sticky setting names
jennings Jun 10, 2022
67a19be
add non-empty validation for sticky_settings names
jennings Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/services/appservice/helpers/shared_schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"strings"

"github.com/Azure/azure-sdk-for-go/services/web/mgmt/2021-02-01/web"
appserviceValidate "github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice/validate"
networkValidate "github.com/hashicorp/terraform-provider-azurerm/internal/services/network/validate"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/validation"
Expand Down Expand Up @@ -1554,7 +1553,6 @@ func StickySettingsSchema() *pluginsdk.Schema {
Optional: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
ValidateFunc: appserviceValidate.AppSettingName,
jennings marked this conversation as resolved.
Show resolved Hide resolved
},
AtLeastOneOf: []string{
"sticky_settings.0.app_setting_names",
Expand All @@ -1568,7 +1566,6 @@ func StickySettingsSchema() *pluginsdk.Schema {
Optional: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
ValidateFunc: appserviceValidate.AppSettingName,
jennings marked this conversation as resolved.
Show resolved Hide resolved
},
AtLeastOneOf: []string{
"sticky_settings.0.app_setting_names",
Expand Down
20 changes: 0 additions & 20 deletions internal/services/appservice/validate/app_setting_name.go
View file
Open in desktop

This file was deleted.