Remove incorrect validation of app service sticky setting names

[jennings]

This validation is too strict. The Azure Portal allows the following name for both app settings and connection strings:

A test: !@#$%^&*()_+-=' ";/?

I can't find a reference for what the valid character set would be, and the names in the app_settings attribute aren't validated at all, so we may as well remove this validation.

Fixes #16612

[jennings]

@jackofallops I would love to get this into an upcoming release because it's blocking my use of sticky_settings entirely. Is there any research I can to do make this easier to review? Or, let me know if I should change something and I can work on it.

[jackofallops]

HI @jennings - Apologies for the delay in review, I've been away for a few days.

Thanks for the catch here, the information I developed this against suggested this was the correct validation, but I should have remembered your point about setting hierarchy, my bad!

Just two minor changes needed, since we can't remove validation entirely here.

Can you add test(s) for these names that cover special characters? Since this is something that can potentially change over time, we'd need to ensure that's covered. Once those changes and tests are in I'll run them on our acceptance suite and we'll get this merged.

Thanks again!

[jennings]

@jackofallops I added validation.StringIsNotEmpty and added my pathological setting name to the four acceptance tests I found that are testing sticky_settings on azurerm_windows_web_app and azurerm_windows_function_app. I hope this is what you intended, if not I can try again. Thanks for your help!

[jackofallops]

Hi @jennings - Thanks for making those changes, this LGTM now 👍

[jackofallops]

Tests looking fine:

Failure here was a transient issue:

[github-actions]

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.