identity: working around the use of legacy identity types #15243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no identity This API differs from others where the API doesn't accept "Type: None" Works around Azure/azure-rest-api-specs#17649
… when the field has a value Works around the upstream issue Azure/azure-rest-api-specs#17650
A user assigned identity won't have a principal id as this field is only for a System Assigned type
jackofallops
approved these changes
Feb 3, 2022
Co-authored-by: jackofallops <[email protected]>
|
Tests look good 👍 |
|
This functionality has been released in v2.95.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly tests detected a a regression in the Storage Account and Stream Analytics resources from #15207, where the Identity types used in these API's don't match the behaviours from other APIs.
In the case of Storage Account that's because the API is using Common Types v3 rather than v4, meaning that
SystemAssigned, UserAssignedisSystemAssigned,UserAssignedwithin this API version. To workaround this version 2.x of the Provider has been updated to support bothSystemAssigned,UserAssignedandSystemAssigned, UserAssigned- and in version 3.0 we'll only supportSystemAssigned, UserAssigned(transforming internally to make these consistent as a part of #15187).In addition there's an API issue when submitting an empty list of UserAssignedIdentities to the API, which returns and error rather than ignoring them, which this works around and is tracked in the upstream issue: Azure/azure-rest-api-specs#17650
In the case of Stream Analytics the API doesn't support sending
Noneas a type, which I've opened an issue to track here: Azure/azure-rest-api-specs#17649