Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating go-azure-helpers to v0.22.0 / updating usages of identity #15207

Merged
merged 9 commits into from
Feb 2, 2022

Conversation

tombuildsstuff
Copy link
Contributor

This PR includes:

  1. dependencies: upgrading github.com/hashicorp/go-azure-helpers to v0.22.0
  2. handling the breaking changes in that upgrade
  3. refactors existing identity blocks to using the new common schema
  4. also refactors identity within the storage account - this is currently Optional & Computed but the Computed value isn't used, so can just be Optional.
  5. synapse workspace, identity becomes required in 3.0 - this is currently defaulted in the create and so computed, but in line with Consistent Identity Blocks across the provider #15187 should be required

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor import ordering but otherwise LGTM 🚀

@tombuildsstuff tombuildsstuff merged commit 4cde499 into main Feb 2, 2022
@tombuildsstuff tombuildsstuff deleted the r/consistent-identity-switch-a-roo branch February 2, 2022 08:17
tombuildsstuff added a commit that referenced this pull request Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This functionality has been released in v2.95.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants