Storage: adding a shim layer for Resource Manager #14220

magodo · 2021-11-17T08:02:03Z

Adding shim mgmt layer for container, queue, shares. Due to the mgmt plane API of the table still lacks of some feature (namely the signedIdentities), the table resource is still data plane only.

This PR also introduced a new feature toggle for the storage in the provider block: use_resource_manager, which controls whether to use data plane API or the mgmt plane API for the affected resources.

The affected resources include:

azurerm_storage_container
azurerm_storage_share
azurerm_storage_queue

Remark

After using the mgmt plane API, the azurerm_storage_container is not able to destroy a "root" container. The test case is commented. The tracking issue is: Storage mgmt API of container can't destroy a "root" container Azure/azure-rest-api-specs#16783
After using the mgmt plane API, there are some properties of the azurerm_storage_share doesn't work. The related test cases are commented. The tracking issue is: Storage Share Mgmt API GET doesn't return some set properties Azure/azure-rest-api-specs#16782
This PR changes the interface definition of the StorageQueuesWrapper to remove the UpdateServiceProperties() and GetServiceProperties(). The reason is that these two methods don't technically belong to the queue resource, but to the queue service. The only place that is using these two methods are in the azurerm_storage_account. Currently, due to the mgmt API of the queue service lacks of the minuteMetrics, hourMetrics and the logging, we have to keep using the data plane API. However, once this gap disappears, we can use the mgmt API of the queue service, just as what has been done for the file service and the blob service in the implementation of the azurerm_storage_account (where they are using the mgmt plane client to set/get service properties). Until then, we can further remove these two methods from the DataPlaneStorageQueueWrapper.

Test

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageContainer_cross|TestAccStorageContainer_mgmt"
=== RUN   TestAccStorageContainer_mgmtBasic
=== PAUSE TestAccStorageContainer_mgmtBasic
=== RUN   TestAccStorageContainer_mgmtUpdate
=== PAUSE TestAccStorageContainer_mgmtUpdate
=== RUN   TestAccStorageContainer_mgmtMetaData
=== PAUSE TestAccStorageContainer_mgmtMetaData
=== RUN   TestAccStorageContainer_mgmtWeb
=== PAUSE TestAccStorageContainer_mgmtWeb
=== RUN   TestAccStorageContainer_crossPlaneUpdate
=== PAUSE TestAccStorageContainer_crossPlaneUpdate
=== CONT  TestAccStorageContainer_mgmtBasic
=== CONT  TestAccStorageContainer_mgmtWeb
=== CONT  TestAccStorageContainer_crossPlaneUpdate
=== CONT  TestAccStorageContainer_mgmtMetaData
=== CONT  TestAccStorageContainer_mgmtUpdate
--- PASS: TestAccStorageContainer_mgmtWeb (175.09s)
--- PASS: TestAccStorageContainer_mgmtBasic (230.97s)
--- PASS: TestAccStorageContainer_crossPlaneUpdate (327.89s)
--- PASS: TestAccStorageContainer_mgmtUpdate (329.37s)
--- PASS: TestAccStorageContainer_mgmtMetaData (418.19s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       418.242s


💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageShare_cross|TestAccStorageShare_mgmt"
=== RUN   TestAccStorageShare_mgmtBasic
=== PAUSE TestAccStorageShare_mgmtBasic
=== RUN   TestAccStorageShare_mgmtMetaData
=== PAUSE TestAccStorageShare_mgmtMetaData
=== RUN   TestAccStorageShare_mgmtUpdateQuota
=== PAUSE TestAccStorageShare_mgmtUpdateQuota
=== RUN   TestAccStorageShare_mgmtLargeQuota
=== PAUSE TestAccStorageShare_mgmtLargeQuota
=== RUN   TestAccStorageShare_mgmtNfsProtocol
=== PAUSE TestAccStorageShare_mgmtNfsProtocol
=== RUN   TestAccStorageShare_crossPlaneMetaData
=== PAUSE TestAccStorageShare_crossPlaneMetaData
=== RUN   TestAccStorageShare_crossPlaneAcl
=== PAUSE TestAccStorageShare_crossPlaneAcl
=== CONT  TestAccStorageShare_mgmtBasic
=== CONT  TestAccStorageShare_mgmtNfsProtocol
=== CONT  TestAccStorageShare_mgmtUpdateQuota
=== CONT  TestAccStorageShare_mgmtMetaData
=== CONT  TestAccStorageShare_mgmtLargeQuota
=== CONT  TestAccStorageShare_crossPlaneAcl
=== CONT  TestAccStorageShare_crossPlaneMetaData
--- PASS: TestAccStorageShare_mgmtNfsProtocol (215.44s)
--- PASS: TestAccStorageShare_mgmtBasic (240.89s)
--- PASS: TestAccStorageShare_mgmtUpdateQuota (306.46s)
--- PASS: TestAccStorageShare_mgmtLargeQuota (310.67s)
--- PASS: TestAccStorageShare_mgmtMetaData (332.07s)
--- PASS: TestAccStorageShare_crossPlaneMetaData (334.02s)
--- PASS: TestAccStorageShare_crossPlaneAcl (341.42s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       341.459s

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageQueue_cross|TestAccStorageQueue_mgmt"
=== RUN   TestAccStorageQueue_mgmtBasic
=== PAUSE TestAccStorageQueue_mgmtBasic
=== RUN   TestAccStorageQueue_mgmtMetaData
=== PAUSE TestAccStorageQueue_mgmtMetaData
=== RUN   TestAccStorageQueue_crossPlaneMetaData
=== PAUSE TestAccStorageQueue_crossPlaneMetaData
=== CONT  TestAccStorageQueue_mgmtBasic
=== CONT  TestAccStorageQueue_crossPlaneMetaData
=== CONT  TestAccStorageQueue_mgmtMetaData
--- PASS: TestAccStorageQueue_mgmtBasic (230.27s)
--- PASS: TestAccStorageQueue_crossPlaneMetaData (303.89s)
--- PASS: TestAccStorageQueue_mgmtMetaData (315.50s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       315.550s

Probably is able to fix issue #2977.

tombuildsstuff

hi @magodo

Thanks for this PR.

I've taken a look through here and left some comments inline - so if we can work through and fix those up then this is otherwise looking good on that front. That said, unfortunately we're blocked from exposing this functionality to users until the Resource Manager API is feature-compatible, so we'll need to ensure that this functionality can't be enabled for the moment (and/or hold on this PR) until the upstream service implements this functionality. Given we've been waiting on the service to implement this functionality for an extended period (so there's no guarantee it'll be fixed anytime soon) I think it's worth doing both in this case for the moment?

Thanks!

internal/provider/features.go

internal/services/storage/shim/containers_mgmt_plane.go

internal/services/storage/shim/queues_mgmt_plane.go

internal/services/storage/shim/containers_mgmt_plane.go

internal/services/storage/storage_share_resource_test.go

internal/services/storage/storage_container_resource_test.go

internal/services/storage/storage_queue_resource_test.go

…ayer

magodo · 2021-12-06T03:53:08Z

@tombuildsstuff Thank you for the review. I've resolved most of them, while keeping some for further discussion. Meanwhile, I've found that the cross planes tests were actually not taking effect, and I've made a fix for that.

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageContainer_resourceManager|TestAccStorageContainer_dataPlane"
=== RUN   TestAccStorageContainer_resourceManagerBasic
=== PAUSE TestAccStorageContainer_resourceManagerBasic
=== RUN   TestAccStorageContainer_resourceManagerUpdate
=== PAUSE TestAccStorageContainer_resourceManagerUpdate
=== RUN   TestAccStorageContainer_resourceManagerMetaData
=== PAUSE TestAccStorageContainer_resourceManagerMetaData
=== RUN   TestAccStorageContainer_resourceManagerRoot
    storage_container_resource_test.go:260:
--- SKIP: TestAccStorageContainer_resourceManagerRoot (0.00s)
=== RUN   TestAccStorageContainer_resourceManagerWeb
=== PAUSE TestAccStorageContainer_resourceManagerWeb
=== RUN   TestAccStorageContainer_dataPlaneThenResourceManager
=== PAUSE TestAccStorageContainer_dataPlaneThenResourceManager
=== RUN   TestAccStorageContainer_resourceManagerThenDataPlane
=== PAUSE TestAccStorageContainer_resourceManagerThenDataPlane
=== CONT  TestAccStorageContainer_resourceManagerBasic
=== CONT  TestAccStorageContainer_resourceManagerWeb
=== CONT  TestAccStorageContainer_resourceManagerThenDataPlane
=== CONT  TestAccStorageContainer_dataPlaneThenResourceManager
=== CONT  TestAccStorageContainer_resourceManagerMetaData
=== CONT  TestAccStorageContainer_resourceManagerUpdate
--- PASS: TestAccStorageContainer_resourceManagerWeb (105.00s)
--- PASS: TestAccStorageContainer_resourceManagerBasic (106.34s)
--- PASS: TestAccStorageContainer_dataPlaneThenResourceManager (124.17s)
--- PASS: TestAccStorageContainer_resourceManagerThenDataPlane (126.36s)
--- PASS: TestAccStorageContainer_resourceManagerUpdate (135.13s)
--- PASS: TestAccStorageContainer_resourceManagerMetaData (163.88s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       163.943s

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageShare_resourceManager|TestAccStorageShare_dataPlane"

=== RUN   TestAccStorageShare_resourceManagerBasic
=== PAUSE TestAccStorageShare_resourceManagerBasic
=== RUN   TestAccStorageShare_resourceManagerMetaData
=== PAUSE TestAccStorageShare_resourceManagerMetaData
=== RUN   TestAccStorageShare_resourceManagerAcl
    storage_share_resource_test.go:244:
--- SKIP: TestAccStorageShare_resourceManagerAcl (0.00s)
=== RUN   TestAccStorageShare_resourceManagerAclGhostedRecall
    storage_share_resource_test.go:269:
--- SKIP: TestAccStorageShare_resourceManagerAclGhostedRecall (0.00s)
=== RUN   TestAccStorageShare_resourceManagerUpdateQuota
=== PAUSE TestAccStorageShare_resourceManagerUpdateQuota
=== RUN   TestAccStorageShare_resourceManagerLargeQuota
=== PAUSE TestAccStorageShare_resourceManagerLargeQuota
=== RUN   TestAccStorageShare_resourceManagerNfsProtocol
=== PAUSE TestAccStorageShare_resourceManagerNfsProtocol
=== RUN   TestAccStorageShare_dataPlaneThenResourceManagerMetaData
=== PAUSE TestAccStorageShare_dataPlaneThenResourceManagerMetaData
=== RUN   TestAccStorageShare_resourceManagerThenDataPlaneMetaData
=== PAUSE TestAccStorageShare_resourceManagerThenDataPlaneMetaData
=== RUN   TestAccStorageShare_dataPlaneThenResourceManagerAcl
    storage_share_resource_test.go:395:
--- SKIP: TestAccStorageShare_dataPlaneThenResourceManagerAcl (0.00s)
=== RUN   TestAccStorageShare_resourceManagerThenDataPlaneAcl
    storage_share_resource_test.go:423:
--- SKIP: TestAccStorageShare_resourceManagerThenDataPlaneAcl (0.00s)
=== CONT  TestAccStorageShare_resourceManagerBasic
=== CONT  TestAccStorageShare_resourceManagerNfsProtocol
=== CONT  TestAccStorageShare_dataPlaneThenResourceManagerMetaData
=== CONT  TestAccStorageShare_resourceManagerThenDataPlaneMetaData
=== CONT  TestAccStorageShare_resourceManagerUpdateQuota
=== CONT  TestAccStorageShare_resourceManagerLargeQuota
=== CONT  TestAccStorageShare_resourceManagerMetaData
--- PASS: TestAccStorageShare_resourceManagerNfsProtocol (108.46s)
--- PASS: TestAccStorageShare_resourceManagerBasic (110.00s)
--- PASS: TestAccStorageShare_resourceManagerLargeQuota (194.12s)
--- PASS: TestAccStorageShare_dataPlaneThenResourceManagerMetaData (204.61s)
--- PASS: TestAccStorageShare_resourceManagerThenDataPlaneMetaData (207.69s)
--- PASS: TestAccStorageShare_resourceManagerMetaData (211.44s)
--- PASS: TestAccStorageShare_resourceManagerUpdateQuota (377.89s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       377.927s

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageQueue_resourceManager|TestAccStorageQueue_dataPlane"

=== RUN   TestAccStorageQueue_resourceManagerBasic
=== PAUSE TestAccStorageQueue_resourceManagerBasic
=== RUN   TestAccStorageQueue_resourceManagerMetaData
=== PAUSE TestAccStorageQueue_resourceManagerMetaData
=== RUN   TestAccStorageQueue_dataPlaneThenResourceManagerMetaData
=== PAUSE TestAccStorageQueue_dataPlaneThenResourceManagerMetaData
=== RUN   TestAccStorageQueue_resourceManagerThenDataPlaneMetaData
=== PAUSE TestAccStorageQueue_resourceManagerThenDataPlaneMetaData
=== CONT  TestAccStorageQueue_resourceManagerBasic
=== CONT  TestAccStorageQueue_dataPlaneThenResourceManagerMetaData
=== CONT  TestAccStorageQueue_resourceManagerMetaData
=== CONT  TestAccStorageQueue_resourceManagerThenDataPlaneMetaData
--- PASS: TestAccStorageQueue_resourceManagerBasic (97.85s)
--- PASS: TestAccStorageQueue_dataPlaneThenResourceManagerMetaData (117.89s)
--- PASS: TestAccStorageQueue_resourceManagerThenDataPlaneMetaData (180.53s)
--- PASS: TestAccStorageQueue_resourceManagerMetaData (187.26s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       187.298s

magodo · 2021-12-08T03:09:51Z

@tombuildsstuff

I've resolved the left two comments:

For the feature toggle, I've now moved them to the v3.0 beta, and the related tests are now added the environment variable to opt in the beta so that they can be tested.
For the queues data plane client, now I'm directly using its data plane client.

Please take another look!

…erraform-provider-azurerm into storage_mgmt_shim_layer

tombuildsstuff · 2022-02-14T14:18:24Z

(as discussed offline) we also need Resource Manager API's for the other (non Blob File/Share File) API calls too e.g.

terraform-provider-azurerm/internal/services/storage/storage_account_resource.go

Lines 1219 to 1244 in 3f2512d

    
           if val, ok := d.GetOk("static_website"); ok { 
        
           	// static website only supported on StorageV2 and BlockBlobStorage 
        
           	if accountKind != string(storage.KindStorageV2) && accountKind != string(storage.KindBlockBlobStorage) { 
        
           		return fmt.Errorf("`static_website` is only supported for StorageV2 and BlockBlobStorage.") 
        
           	} 
        
           	storageClient := meta.(*clients.Client).Storage 
        
           	account, err := storageClient.FindAccount(ctx, id.Name) 
        
           	if err != nil { 
        
           		return fmt.Errorf("retrieving Account %q: %s", id.Name, err) 
        
           	} 
        
           	if account == nil { 
        
           		return fmt.Errorf("Unable to locate Storage Account %q!", id.Name) 
        
           	} 
        
           	accountsClient, err := storageClient.AccountsDataPlaneClient(ctx, *account) 
        
           	if err != nil { 
        
           		return fmt.Errorf("building Accounts Data Plane Client: %s", err) 
        
           	} 
        
           	staticWebsiteProps := expandStaticWebsiteProperties(val.([]interface{})) 
        
           	if _, err = accountsClient.SetServiceProperties(ctx, id.Name, staticWebsiteProps); err != nil { 
        
           		return fmt.Errorf("updating Azure Storage Account `static_website` %q: %+v", id.Name, err) 
        
           	} 
        
           }

Else we're unable to read these once Network Rules are enabled

tombuildsstuff · 2022-06-29T16:35:24Z

@magodo is there an update from the Service Team on when these fixes will go live?

tombuildsstuff · 2022-06-29T16:35:45Z

... I hit comment but 🙈

dhirschfeld · 2022-06-30T00:29:16Z

... I hit comment but 🙈

https://twitter.com/mariorod1/status/1542189296240713730

magodo · 2022-06-30T01:33:31Z

@magodo Zhaoting Weng FTE is there an update from the Service Team on when these fixes will go live?

Just saw an update in the internal ticket opened for resolving this the issues I listed above.

…ayer

magodo · 2022-07-11T09:19:03Z

@tombuildsstuff Merged with the main branch, and all the related tests are passing. Though there is no news here as all those issues are still in progress, except Azure/azure-rest-api-specs#17007, that seems to be fixed in the 2021-09-01, where I have another PR to update the API version to it: #17523.

Test

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageShare_resourceManager|TestAccStorageShare_dataPlane"

=== RUN TestAccStorageShare_resourceManagerBasic
=== PAUSE TestAccStorageShare_resourceManagerBasic
=== RUN TestAccStorageShare_resourceManagerMetaData
=== PAUSE TestAccStorageShare_resourceManagerMetaData
=== RUN TestAccStorageShare_resourceManagerAcl
storage_share_resource_test.go:311:
--- SKIP: TestAccStorageShare_resourceManagerAcl (0.00s)
=== RUN TestAccStorageShare_resourceManagerAclGhostedRecall
storage_share_resource_test.go:336:
--- SKIP: TestAccStorageShare_resourceManagerAclGhostedRecall (0.00s)
=== RUN TestAccStorageShare_resourceManagerUpdateQuota
=== PAUSE TestAccStorageShare_resourceManagerUpdateQuota
=== RUN TestAccStorageShare_resourceManagerLargeQuota
=== PAUSE TestAccStorageShare_resourceManagerLargeQuota
=== RUN TestAccStorageShare_resourceManagerNfsProtocol
=== PAUSE TestAccStorageShare_resourceManagerNfsProtocol
=== RUN TestAccStorageShare_dataPlaneThenResourceManagerMetaData
=== PAUSE TestAccStorageShare_dataPlaneThenResourceManagerMetaData
=== RUN TestAccStorageShare_resourceManagerThenDataPlaneMetaData
=== PAUSE TestAccStorageShare_resourceManagerThenDataPlaneMetaData
=== RUN TestAccStorageShare_dataPlaneThenResourceManagerAcl
storage_share_resource_test.go:462:
--- SKIP: TestAccStorageShare_dataPlaneThenResourceManagerAcl (0.00s)
=== RUN TestAccStorageShare_resourceManagerThenDataPlaneAcl
storage_share_resource_test.go:490:
--- SKIP: TestAccStorageShare_resourceManagerThenDataPlaneAcl (0.00s)
=== CONT TestAccStorageShare_resourceManagerBasic
=== CONT TestAccStorageShare_resourceManagerNfsProtocol
=== CONT TestAccStorageShare_resourceManagerUpdateQuota
=== CONT TestAccStorageShare_resourceManagerLargeQuota
=== CONT TestAccStorageShare_resourceManagerThenDataPlaneMetaData
=== CONT TestAccStorageShare_dataPlaneThenResourceManagerMetaData
=== CONT TestAccStorageShare_resourceManagerMetaData
--- PASS: TestAccStorageShare_resourceManagerNfsProtocol (89.75s)
--- PASS: TestAccStorageShare_resourceManagerBasic (96.84s)
--- PASS: TestAccStorageShare_resourceManagerLargeQuota (110.31s)
--- PASS: TestAccStorageShare_resourceManagerThenDataPlaneMetaData (176.03s)
--- PASS: TestAccStorageShare_dataPlaneThenResourceManagerMetaData (178.06s)
--- PASS: TestAccStorageShare_resourceManagerMetaData (183.42s)
--- PASS: TestAccStorageShare_resourceManagerUpdateQuota (211.97s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/storage 212.005s

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageContainer_resourceManager|TestAccStorageContainer_dataPlane"

=== RUN TestAccStorageContainer_resourceManagerBasic
=== PAUSE TestAccStorageContainer_resourceManagerBasic
=== RUN TestAccStorageContainer_resourceManagerUpdate
=== PAUSE TestAccStorageContainer_resourceManagerUpdate
=== RUN TestAccStorageContainer_resourceManagerMetaData
=== PAUSE TestAccStorageContainer_resourceManagerMetaData
=== RUN TestAccStorageContainer_resourceManagerRoot
storage_container_resource_test.go:260:
--- SKIP: TestAccStorageContainer_resourceManagerRoot (0.00s)
=== RUN TestAccStorageContainer_resourceManagerWeb
=== PAUSE TestAccStorageContainer_resourceManagerWeb
=== RUN TestAccStorageContainer_dataPlaneThenResourceManager
=== PAUSE TestAccStorageContainer_dataPlaneThenResourceManager
=== RUN TestAccStorageContainer_resourceManagerThenDataPlane
=== PAUSE TestAccStorageContainer_resourceManagerThenDataPlane
=== CONT TestAccStorageContainer_resourceManagerBasic
=== CONT TestAccStorageContainer_resourceManagerThenDataPlane
=== CONT TestAccStorageContainer_resourceManagerMetaData
=== CONT TestAccStorageContainer_resourceManagerWeb
=== CONT TestAccStorageContainer_resourceManagerUpdate
=== CONT TestAccStorageContainer_dataPlaneThenResourceManager
--- PASS: TestAccStorageContainer_resourceManagerThenDataPlane (113.54s)
--- PASS: TestAccStorageContainer_dataPlaneThenResourceManager (116.78s)
--- PASS: TestAccStorageContainer_resourceManagerBasic (161.38s)
--- PASS: TestAccStorageContainer_resourceManagerWeb (162.38s)
--- PASS: TestAccStorageContainer_resourceManagerUpdate (187.95s)
--- PASS: TestAccStorageContainer_resourceManagerMetaData (213.48s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/storage 213.504s

💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run="TestAccStorageQueue_resourceManager|TestAccStorageQueue_dataPlane"

=== RUN TestAccStorageQueue_resourceManagerBasic
=== PAUSE TestAccStorageQueue_resourceManagerBasic
=== RUN TestAccStorageQueue_resourceManagerMetaData
=== PAUSE TestAccStorageQueue_resourceManagerMetaData
=== RUN TestAccStorageQueue_dataPlaneThenResourceManagerMetaData
=== PAUSE TestAccStorageQueue_dataPlaneThenResourceManagerMetaData
=== RUN TestAccStorageQueue_resourceManagerThenDataPlaneMetaData
=== PAUSE TestAccStorageQueue_resourceManagerThenDataPlaneMetaData
=== CONT TestAccStorageQueue_resourceManagerBasic
=== CONT TestAccStorageQueue_dataPlaneThenResourceManagerMetaData
=== CONT TestAccStorageQueue_resourceManagerMetaData
=== CONT TestAccStorageQueue_resourceManagerThenDataPlaneMetaData
--- PASS: TestAccStorageQueue_resourceManagerBasic (154.83s)
--- PASS: TestAccStorageQueue_dataPlaneThenResourceManagerMetaData (171.90s)
--- PASS: TestAccStorageQueue_resourceManagerThenDataPlaneMetaData (174.94s)
--- PASS: TestAccStorageQueue_resourceManagerMetaData (181.47s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/storage 181.491s

…ayer

magodo · 2022-10-08T04:32:42Z

@tombuildsstuff A tiny update to the #14220 (comment). With #17523 merged, I now opt in the shim layer for the table client. However, the API has some issue, which makes the ACL update failed, which is tracked in Azure/azure-rest-api-specs#17007 (comment) (I've also asked the service team internally).

katbyte · 2023-01-09T15:44:25Z

@magodo - any updates from the service team on this?

magodo · 2023-01-10T01:01:53Z

@katbyte Unfortunately, there is no update from the service team at the moment.

tombuildsstuff · 2023-02-13T17:33:19Z

@magodo since this is still waiting on the Service Team, rather than leaving this PR open indefinitely I'm going to temporarily close this PR for the moment - once the Service Team's shipped the changes we can re-open this / fix up the merge conflicts and look to get this merged, however.

github-actions · 2023-04-09T02:08:55Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

magodo added 4 commits November 17, 2021 10:47

basic shim layer support

b236d93

provider feature: add storage for the use_resource_manager toggle

907ca7b

pass tests for container/queue/shares

3ac3a60

change comment

02b9bb2

github-actions bot added the size/XL label Nov 17, 2021

fmt

c1d3357

tombuildsstuff added enhancement service/storage labels Nov 17, 2021

tombuildsstuff self-assigned this Nov 17, 2021

tombuildsstuff suggested changes Dec 4, 2021

View reviewed changes

tombuildsstuff added this to the Blocked milestone Dec 4, 2021

tombuildsstuff added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Dec 4, 2021

magodo added 4 commits December 6, 2021 10:48

resolve comments

9fc467b

Merge remote-tracking branch 'upstream/main' into storage_mgmt_shim_l…

a850dd1

…ayer

typo

64fec6b

fix the cross plane test

65429fd

magodo added 2 commits December 6, 2021 12:41

linting

e86d3e5

linter

3dbb012

tombuildsstuff assigned magodo and unassigned tombuildsstuff Dec 6, 2021

tombuildsstuff added the waiting-response label Dec 6, 2021

tombuildsstuff changed the title ~~Storage mgmt shim layer~~ Storage: adding a shim layer for Resource Manager Dec 6, 2021

magodo added 2 commits December 8, 2021 10:48

make the feature toggle functional for 3.0-beta

446802b

storage account: directly use queue data plane client

cc7089b

github-actions bot removed the waiting-response label Dec 8, 2021

magodo added 2 commits December 8, 2021 11:13

Merge branch 'storage_mgmt_shim_layer' of https://github.com/magodo/t…

1015fb7

…erraform-provider-azurerm into storage_mgmt_shim_layer

lint

d232cf0

kash-yap mentioned this pull request Dec 9, 2021

Cannot create azurerm_storage_container in azurerm_storage_account that uses network_rules #2977

Closed

tombuildsstuff closed this Jun 29, 2022

tombuildsstuff reopened this Jun 29, 2022

tombuildsstuff closed this Jun 29, 2022

tombuildsstuff reopened this Jun 29, 2022

magodo added 5 commits July 11, 2022 15:13

Merge remote-tracking branch 'upstream/main' into storage_mgmt_shim_l…

185e910

…ayer

Fix after merge

7b44e48

terrafmt

f31d1fd

Clean up some code and add links to known issues

fddedfc

Fix incorrect testcase tpl

e1aa42d

This comment was marked as off-topic.

Sign in to view

Amier3 mentioned this pull request Aug 30, 2022

azurerm_storage_account - add feature to not access the data-plane #17648

Closed

magodo added 3 commits October 8, 2022 10:13

Merge remote-tracking branch 'upstream/main' into storage_mgmt_shim_l…

bfeb857

…ayer

Use the correct api version

8b6fa00

Adding the table to using resource manager

3a4c5bd

magodo mentioned this pull request Oct 18, 2022

Please make a seperate resource for public_network_access_enabled in azurerm_storage_account #18788

Closed

1 task

tombuildsstuff closed this Feb 13, 2023

magodo mentioned this pull request Mar 9, 2023

Terraform wants to reach storage account static website endpoint even when none will be created #20257

Closed

1 task

github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage: adding a shim layer for Resource Manager #14220

Storage: adding a shim layer for Resource Manager #14220

magodo commented Nov 17, 2021 •

edited

Loading

tombuildsstuff left a comment

magodo commented Dec 6, 2021

magodo commented Dec 8, 2021 •

edited

Loading

tombuildsstuff commented Feb 14, 2022

tombuildsstuff commented Jun 29, 2022

tombuildsstuff commented Jun 29, 2022

dhirschfeld commented Jun 30, 2022

magodo commented Jun 30, 2022 •

edited

Loading

magodo commented Jul 11, 2022 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

magodo commented Oct 8, 2022

katbyte commented Jan 9, 2023

magodo commented Jan 10, 2023

tombuildsstuff commented Feb 13, 2023

github-actions bot commented Apr 9, 2023

Storage: adding a shim layer for Resource Manager #14220

Storage: adding a shim layer for Resource Manager #14220

Conversation

magodo commented Nov 17, 2021 • edited Loading

Remark

Test

tombuildsstuff left a comment

Choose a reason for hiding this comment

magodo commented Dec 6, 2021

magodo commented Dec 8, 2021 • edited Loading

tombuildsstuff commented Feb 14, 2022

tombuildsstuff commented Jun 29, 2022

tombuildsstuff commented Jun 29, 2022

dhirschfeld commented Jun 30, 2022

magodo commented Jun 30, 2022 • edited Loading

magodo commented Jul 11, 2022 • edited Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

magodo commented Oct 8, 2022

katbyte commented Jan 9, 2023

magodo commented Jan 10, 2023

tombuildsstuff commented Feb 13, 2023

github-actions bot commented Apr 9, 2023

magodo commented Nov 17, 2021 •

edited

Loading

magodo commented Dec 8, 2021 •

edited

Loading

magodo commented Jun 30, 2022 •

edited

Loading

magodo commented Jul 11, 2022 •

edited

Loading