Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Share Mgmt API GET doesn't return some set properties #16782

Open
magodo opened this issue Nov 17, 2021 · 1 comment
Open

Storage Share Mgmt API GET doesn't return some set properties #16782

magodo opened this issue Nov 17, 2021 · 1 comment
Labels
Storage Storage Service (Queues, Blobs, Files)

Comments

@magodo
Copy link
Contributor

magodo commented Nov 17, 2021

Using the 2021-04-01 storage share mgmt API to create a share, a follow up GET doesn't return all the set properties.

Missing enabledProtocols when set to SMB

The PUT request payload specifies the enabledProtocols to be SMB, while the follow up GET response doesn't contain the enabledProtocols at all. On the other hand, the data plane GET returns it.

The PUT request:

PUT https://management.azure.com/subscriptions/xxx/resourceGroups/acctestRG-211117135426017553/providers/Microsoft.Storage/storageAccounts/acctestaccw8dz2/fileServices/default/shares/testsharew8dz2?api-version=2021-04-01 

{
  "properties": {
    "enabledProtocols": "SMB",
    "metadata": {},
    "shareQuota": 5120
  }
}

The GET response:

GET https://management.azure.com/subscriptions/xxx/resourceGroups/acctestRG-211117135426017553/providers/Microsoft.Storage/storageAccounts/acctestaccw8dz2/fileServices/default/shares/testsharew8dz2?api-version=2021-04-01 

{
  "etag": "\"0x8D9A98EE403362D\"",
  "id": "/subscriptions/xxx/resourceGroups/acctestRG-211117135426017553/providers/Microsoft.Storage/storageAccounts/acctestaccw8dz2/fileServices/default/shares/testsharew8dz2",
  "name": "testsharew8dz2",
  "properties": {
    "accessTier": "TransactionOptimized",
    "accessTierChangeTime": "2021-11-17T05:55:41.0000000Z",
    "lastModifiedTime": "2021-11-17T05:55:42.0000000Z",
    "leaseState": "available",
    "leaseStatus": "unlocked",
    "shareQuota": 5120,
    "signedIdentifiers": []
  },
  "type": "Microsoft.Storage/storageAccounts/fileServices/shares"
}

Missing the start and expiry for the accessPolicy

The PATCH has set the start, expiry and the permission for the accessPolicy, while the follow up GET only returns the permission. While, the data plane API returns all of them.

The PATCH request:

PATCH https://management.azure.com/subscriptions/xxx/resourceGroups/acctestRG-211117144101410558/providers/Microsoft.Storage/storageAccounts/acctestacc00e99/fileServices/default/shares/testshare00e99?api-version=2021-04-01

{
  "properties": {
    "signedIdentifiers": [
      {
        "accessPolicy": {
          "expiry": "2019-07-02T10:38:21Z",
          "permission": "rwd",
          "start": "2019-07-02T09:38:21Z"
        },
        "id": "MTIzNDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTI"
      }
    ]
  }
}

The GET response:

GET https://management.azure.com/subscriptions/xxx/resourceGroups/acctestRG-211117144101410558/providers/Microsoft.Storage/storageAccounts/acctestacc00e99/fileServices/default/shares/testshare00e99?api-version=2021-04-01

{
  "etag": "\"0x8D9A99566A0F73A\"",
  "id": "/subscriptions/67a9759d-d099-4aa8-8675-e6cfd669c3f4/resourceGroups/acctestRG-211117144101410558/providers/Microsoft.Storage/storageAccounts/acctestacc00e99/fileServices/default/shares/testshare00e99",
  "name": "testshare00e99",
  "properties": {
    "accessTier": "TransactionOptimized",
    "accessTierChangeTime": "2021-11-17T06:42:17.0000000Z",
    "lastModifiedTime": "2021-11-17T06:42:18.0000000Z",
    "leaseState": "available",
    "leaseStatus": "unlocked",
    "shareQuota": 5120,
    "signedIdentifiers": [
      {
        "accessPolicy": { "permission": "rwd" },
        "id": "MTIzNDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTI"
      }
    ]
  },
  "type": "Microsoft.Storage/storageAccounts/fileServices/shares"
}
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 17, 2021
@blueww
Copy link
Member

blueww commented Nov 17, 2021

@HimanshuChhabra , @zfchen95
Would you please help to look at the SRP server issue?

@magodo magodo changed the title Storage Share Mgmt API GET doesn't return enabledProtocols Storage Share Mgmt API GET doesn't return some set properties Nov 17, 2021
@leni-msft leni-msft added Storage Storage Service (Queues, Blobs, Files) and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

3 participants