-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_mssql_server
: Support for azuread_authentication_only
#13754
azurerm_mssql_server
: Support for azuread_authentication_only
#13754
Conversation
541939e
to
8ebace3
Compare
2af0c74
to
5dabc10
Compare
5dabc10
to
be8e8c0
Compare
f15c76e
to
3d05f49
Compare
a85f6b2
to
2cb7c1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aristosvo - aside from one comment on the property name this looks good!
azurerm_mssql_server
: Support for azuread_only_authentication
azurerm_mssql_server
: Support for azuread_authentication_only
It would be easiest if #13753 was merged first, these PRs conflict with each other. I'll rebase it as soon it's merged. |
6870e6b
to
c6ed8e6
Compare
@katbyte Rebase executed, specific test passing: ❯ go install && make acctests SERVICE='mssql' TESTARGS='-run=TestAccMsSqlServer_azureadAdmin'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlServer_azureadAdmin -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccMsSqlServer_azureadAdmin
=== PAUSE TestAccMsSqlServer_azureadAdmin
=== RUN TestAccMsSqlServer_azureadAdminUpdate
=== PAUSE TestAccMsSqlServer_azureadAdminUpdate
=== CONT TestAccMsSqlServer_azureadAdmin
=== CONT TestAccMsSqlServer_azureadAdminUpdate
--- PASS: TestAccMsSqlServer_azureadAdmin (605.04s)
--- PASS: TestAccMsSqlServer_azureadAdminUpdate (968.51s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql 970.095s |
This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #12965
Fixes half of #12252,
azurerm_sql_active_directory_administrator
is out of scope of this PR as this also requires an update of the API versionAcceptance Test