Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/mssql_server: support for azuread_only_authentication #12965

Closed
ulankford opened this issue Aug 12, 2021 · 3 comments · Fixed by #13754
Closed

r/mssql_server: support for azuread_only_authentication #12965

ulankford opened this issue Aug 12, 2021 · 3 comments · Fixed by #13754
Labels
enhancement service/mssql Microsoft SQL Server
Milestone

Comments

@ulankford
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Is it possible to also set to 'True' or 'False' the ability to set Azure AD Only Authentication (azureADOnlyAuthentications) as part of this resource?
https://docs.microsoft.com/en-us/azure/templates/microsoft.sql/servers/azureadonlyauthentications?tabs=bicep

It's great that one can set an AD Administrator as the first step to enable Azure AD Single Sign-On, but there doesn't seem to be a way to enable AD Only Authentication, apart from the GUI, or using the Azure CLI

New or Affected Resource(s)

  • azurerm_sql_active_directory_administrator

Potential Terraform Configuration

resource "azurerm_sql_active_directory_administrator" "adadmin" {
  server_name         = azurerm_mssql_server.sqlServer.name
  resource_group_name = azurerm_resource_group.rg.name
  login               = "sqladmin"
  tenant_id           = data.azurerm_client_config.current1.tenant_id
  object_id           = data.azurerm_client_config.current1.object_id

  ad_only_auth    = "true"
}

References

@tombuildsstuff tombuildsstuff changed the title Support for [thing] r/mssql_server: support for azuread_only_authentication Aug 12, 2021
@ajklotz
Copy link

ajklotz commented Sep 8, 2021

This might be something you should set at the azurerm_mssql_server resource instead of azurerm_sql_active_directory_administrator - just a suggestion if this gets implemented

katbyte pushed a commit that referenced this issue Oct 21, 2021
…3754)

Fixes #12965
Fixes half of #12252, azurerm_sql_active_directory_administrator is out of scope of this PR as this also requires an update of the API version
@katbyte katbyte added this to the v2.82.0 milestone Oct 21, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants