Support for private_link_access in azurerm_storage_account
#11629
Conversation
ghost
added
| * `resource_id` - (Required) The resource id of the `azurerm_private_endpoint` of the resource access rule. | ||
|
|
||
| * `tenant_id` - (Optional) The tenant id of the `azurerm_private_endpoint` of the resource access rule. Defaults to the current tenant id. |
There was a problem hiding this comment.
if this is just for private link
| * `resource_id` - (Required) The resource id of the `azurerm_private_endpoint` of the resource access rule. | |
| * `tenant_id` - (Optional) The tenant id of the `azurerm_private_endpoint` of the resource access rule. Defaults to the current tenant id. | |
| * `private_endpoint_id` - (Required) The resource id of the `azurerm_private_endpoint` of the resource access rule. | |
| * `private_endpoint_tenant_id` - (Optional) The tenant id of the `azurerm_private_endpoint` of the resource access rule. Defaults to the current tenant id. |
and maybe pulling these out to the top level?
There was a problem hiding this comment.
Since there could be several private_endpoint to be connected, shall I keep the block and change the block name?
There was a problem hiding this comment.
I've update the acctests to connect two private endpoints.
|
Thanks kt for your comments. Please continue reviewing. === RUN TestAccStorageAccount_privateEndpointAccessRules === RUN TestAccStorageAccountNetworkRules_privateEndpointAccessRules |
azurerm/internal/services/storage/storage_account_network_rules_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_account_network_rules_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_account_network_rules_resource.go
Outdated
Show resolved
Hide resolved
yupwei68
changed the title
resource_access_rules in azurerm_storage_accountprivate_link_access in azurerm_storage_account
|
Thanks kt for your comments. Please continue reviewing. --- PASS: TestAccStorageAccountNetworkRules_privateLinkAccess (407.79s) |
|
This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.59.0"
}
# ... other configuration ... |
…corp#11629) Fix hashicorp#11628 === RUN TestAccStorageAccount_resourceAccessRules === PAUSE TestAccStorageAccount_resourceAccessRules === CONT TestAccStorageAccount_resourceAccessRules --- PASS: TestAccStorageAccount_resourceAccessRules (465.11s) === RUN TestAccStorageAccountNetworkRules_resourceAccessRules === PAUSE TestAccStorageAccountNetworkRules_resourceAccessRules === CONT TestAccStorageAccountNetworkRules_resourceAccessRules --- PASS: TestAccStorageAccountNetworkRules_resourceAccessRules (381.65s)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix #11628
=== RUN TestAccStorageAccount_resourceAccessRules
=== PAUSE TestAccStorageAccount_resourceAccessRules
=== CONT TestAccStorageAccount_resourceAccessRules
--- PASS: TestAccStorageAccount_resourceAccessRules (465.11s)
=== RUN TestAccStorageAccountNetworkRules_resourceAccessRules
=== PAUSE TestAccStorageAccountNetworkRules_resourceAccessRules
=== CONT TestAccStorageAccountNetworkRules_resourceAccessRules
--- PASS: TestAccStorageAccountNetworkRules_resourceAccessRules (381.65s)